Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1124)

Unified Diff: build/config/clang/BUILD.gn

Issue 142053002: Hook up clang_use_chrome_plugins to the GN build. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/gyp_chromium » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/clang/BUILD.gn
diff --git a/build/config/clang/BUILD.gn b/build/config/clang/BUILD.gn
index 202b195f92f90d91e8affba41a64919535be6680..9f99755a5f4f6836eb444b85a9480f1c15e8960d 100644
--- a/build/config/clang/BUILD.gn
+++ b/build/config/clang/BUILD.gn
@@ -2,24 +2,32 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
+declare_args() {
+ # Indicates if the build should use the Chrome-specific plugins for enforcing
+ # coding guidelines, etc.
+ clang_use_chrome_plugins = true
+}
+
config("find_bad_constructs") {
- cflags = [
- "-Xclang", "-load",
- "-Xclang",
- ]
+ if (clang_use_chrome_plugins) {
+ cflags = [
+ "-Xclang", "-load",
+ "-Xclang",
+ ]
- if (is_mac) {
- cflags += [ rebase_path(
- "//third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib",
- ".", root_build_dir) ]
- } else if (is_linux) {
- cflags += [ rebase_path(
- "//third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so",
- ".", root_build_dir) ]
- }
+ if (is_mac) {
+ cflags += [ rebase_path(
+ "//third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib",
+ ".", root_build_dir) ]
+ } else if (is_linux) {
+ cflags += [ rebase_path(
+ "//third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so",
+ ".", root_build_dir) ]
+ }
- cflags += [
- "-Xclang", "-add-plugin",
- "-Xclang", "find-bad-constructs",
- ]
+ cflags += [
+ "-Xclang", "-add-plugin",
+ "-Xclang", "find-bad-constructs",
+ ]
+ }
}
« no previous file with comments | « no previous file | build/gyp_chromium » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698