Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Side by Side Diff: build/config/clang/BUILD.gn

Issue 142053002: Hook up clang_use_chrome_plugins to the GN build. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | build/gyp_chromium » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 declare_args() {
6 # Indicates if the build should use the Chrome-specific plugins for enforcing
7 # coding guidelines, etc.
8 clang_use_chrome_plugins = true
9 }
10
5 config("find_bad_constructs") { 11 config("find_bad_constructs") {
6 cflags = [ 12 if (clang_use_chrome_plugins) {
7 "-Xclang", "-load", 13 cflags = [
8 "-Xclang", 14 "-Xclang", "-load",
9 ] 15 "-Xclang",
16 ]
10 17
11 if (is_mac) { 18 if (is_mac) {
12 cflags += [ rebase_path( 19 cflags += [ rebase_path(
13 "//third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib", 20 "//third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib ",
14 ".", root_build_dir) ] 21 ".", root_build_dir) ]
15 } else if (is_linux) { 22 } else if (is_linux) {
16 cflags += [ rebase_path( 23 cflags += [ rebase_path(
17 "//third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so", 24 "//third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so",
18 ".", root_build_dir) ] 25 ".", root_build_dir) ]
26 }
27
28 cflags += [
29 "-Xclang", "-add-plugin",
30 "-Xclang", "find-bad-constructs",
31 ]
19 } 32 }
20
21 cflags += [
22 "-Xclang", "-add-plugin",
23 "-Xclang", "find-bad-constructs",
24 ]
25 } 33 }
OLDNEW
« no previous file with comments | « no previous file | build/gyp_chromium » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698