Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2753)

Unified Diff: build/gyp_chromium

Issue 142053002: Hook up clang_use_chrome_plugins to the GN build. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/clang/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/gyp_chromium
diff --git a/build/gyp_chromium b/build/gyp_chromium
index f8fa93664642b73b23e673a31e8225c235e0dc1d..b8b328e534ac66be0d8ec06deaf642203961df45 100755
--- a/build/gyp_chromium
+++ b/build/gyp_chromium
@@ -164,7 +164,6 @@ def GetArgsStringForGN(supplemental_files):
# host_os=linux Probably can skip, GN knows the host OS.
# order_text_section=<path> http://crbug.com/330299
# chromium_win_pch=0 http://crbug.com/297678
- # clang_use_chrome_plugins=1 http://crbug.com/330298
# chromium_ios_signing=0 http://crbug.com/330302
# linux_use_tcmalloc=0 http://crbug.com/330303
# release_extra_flags=... http://crbug.com/330305
@@ -177,6 +176,7 @@ def GetArgsStringForGN(supplemental_files):
('buildtype', 'Official', 'is_official_build=true'),
('component', 'shared_library', 'is_component_build=true'),
('clang', '1', 'is_clang=true'),
+ ('clang_use_chrome_plugins', '0', 'clang_use_chrome_plugins=false'),
('disable_glibcxx_debug', '1', 'disable_glibcxx_debug=true'),
('target_arch', 'ia32', 'cpu_arch="x86"'),
('target_arch', 'x64', 'cpu_arch="x64" force_win64=true'),
« no previous file with comments | « build/config/clang/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698