Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Unified Diff: runtime/bin/process_patch.dart

Issue 1420443002: Corrects cleanup on an error during Process startup (Closed) Base URL: git@github.com:dart-lang/sdk.git@stable
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/process_patch.dart
diff --git a/runtime/bin/process_patch.dart b/runtime/bin/process_patch.dart
index b6d40ee7a3eea18e8b8ee33fb6c0fd75f008734d..c6f9533eb68078130f2fc1d83febcdcb5f078c87 100644
--- a/runtime/bin/process_patch.dart
+++ b/runtime/bin/process_patch.dart
@@ -409,6 +409,7 @@ class _ProcessImpl extends _ProcessImplNativeWrapper with _ServiceObject
? null : _exitHandler._nativeSocket,
status);
if (!success) {
+ _processes.remove(_serviceId);
completer.completeError(
new ProcessException(_path,
_arguments,
@@ -471,6 +472,7 @@ class _ProcessImpl extends _ProcessImplNativeWrapper with _ServiceObject
_exitHandler._nativeSocket,
status);
if (!success) {
+ _processes.remove(_serviceId);
throw new ProcessException(_path,
_arguments,
status._errorMessage,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698