Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Issue 1420403005: [Password Manager] Enables opening origins on chrome://settings/passwords by a left click (no need … (Closed)

Created:
5 years, 1 month ago by kolos1
Modified:
5 years, 1 month ago
Reviewers:
Evan Stade
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, vabr+watchlist_chromium.org, arv+watch_chromium.org, gcasto+watchlist_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@issue_483915
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Password Manager] Enables opening origins on chrome://settings/passwords by a left click (no need to use the 'Open link in new tab' in the context menu). BUG=550270 Committed: https://crrev.com/cd992c08b465526201070ee57904452b46ad63ca Cr-Commit-Position: refs/heads/master@{#357781}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/browser/resources/options/password_manager_list.js View 2 chunks +2 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 9 (4 generated)
kolos1
Hi Evan, Please also review this small update. It enables opening origins with a single ...
5 years, 1 month ago (2015-11-02 12:45:10 UTC) #2
Evan Stade
lgtm
5 years, 1 month ago (2015-11-03 22:16:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1420403005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1420403005/1
5 years, 1 month ago (2015-11-04 07:44:26 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-04 08:19:47 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-11-04 08:20:41 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cd992c08b465526201070ee57904452b46ad63ca
Cr-Commit-Position: refs/heads/master@{#357781}

Powered by Google App Engine
This is Rietveld 408576698