Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6551)

Unified Diff: chrome/browser/resources/options/password_manager_list.js

Issue 1420403005: [Password Manager] Enables opening origins on chrome://settings/passwords by a left click (no need … (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@issue_483915
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/options/password_manager_list.js
diff --git a/chrome/browser/resources/options/password_manager_list.js b/chrome/browser/resources/options/password_manager_list.js
index c4af28d4ba7eec8d0731da282629d46338877f75..85cf0aef2165c58d6e13861d57fa6e599bc71f5a 100644
--- a/chrome/browser/resources/options/password_manager_list.js
+++ b/chrome/browser/resources/options/password_manager_list.js
@@ -75,6 +75,7 @@ cr.define('options.passwordManager', function() {
'title', getTitleForPasswordOrigin(this.url, this.isUrlSecure));
var urlLink = this.ownerDocument.createElement('a');
urlLink.href = this.url;
+ urlLink.setAttribute('target', '_blank');
urlLink.textContent = this.shownUrl.split('').reverse().join('');
urlDiv.appendChild(urlLink);
urlDiv.style.backgroundImage = getFaviconImageSet(
@@ -323,6 +324,7 @@ cr.define('options.passwordManager', function() {
var urlLink = this.ownerDocument.createElement('a');
urlLink.href = this.url;
urlLink.textContent = this.shownUrl.split('').reverse().join('');
+ urlLink.setAttribute('target', '_blank');
urlDiv.appendChild(urlLink);
urlDiv.style.backgroundImage = getFaviconImageSet(
'origin/' + this.url, 16);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698