Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 1415333009: [Password Manager] Recovers implied focus traverse on chrome://settings/passwords (Closed)

Created:
5 years, 1 month ago by kolos1
Modified:
5 years, 1 month ago
Reviewers:
Evan Stade
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, vabr+watchlist_chromium.org, arv+watch_chromium.org, gcasto+watchlist_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@issue_550270
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Password Manager] Recovers implied focus traverse on chrome://settings/passwords CL on copiable username and origin doesn't preserve implied navigation using Tab key. BUG=551345 Committed: https://crrev.com/e766d85737583f7512f877d66ed15060c2b5e977 Cr-Commit-Position: refs/heads/master@{#357847}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M chrome/browser/resources/options/password_manager_list.js View 1 3 chunks +6 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (3 generated)
kolos1
Hi Evan, Please review these small changes. The CL on copiable username and origin doesn't ...
5 years, 1 month ago (2015-11-04 13:20:42 UTC) #2
Evan Stade
lgtm https://codereview.chromium.org/1415333009/diff/1/chrome/browser/resources/options/password_manager_list.js File chrome/browser/resources/options/password_manager_list.js (right): https://codereview.chromium.org/1415333009/diff/1/chrome/browser/resources/options/password_manager_list.js#newcode84 chrome/browser/resources/options/password_manager_list.js:84: this.urlField = urlLink; nit: s/urlField/urlLink
5 years, 1 month ago (2015-11-04 16:44:43 UTC) #3
kolos1
https://codereview.chromium.org/1415333009/diff/1/chrome/browser/resources/options/password_manager_list.js File chrome/browser/resources/options/password_manager_list.js (right): https://codereview.chromium.org/1415333009/diff/1/chrome/browser/resources/options/password_manager_list.js#newcode84 chrome/browser/resources/options/password_manager_list.js:84: this.urlField = urlLink; On 2015/11/04 16:44:42, Evan Stade (ooo) ...
5 years, 1 month ago (2015-11-04 16:52:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1415333009/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1415333009/20001
5 years, 1 month ago (2015-11-04 16:53:34 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-04 17:53:56 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-11-04 17:55:06 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e766d85737583f7512f877d66ed15060c2b5e977
Cr-Commit-Position: refs/heads/master@{#357847}

Powered by Google App Engine
This is Rietveld 408576698