|
|
Created:
6 years, 11 months ago by Robert Sesek Modified:
6 years, 11 months ago CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium, ccameron Base URL:
https://chromium.googlesource.com/chromium/blink.git@master Visibility:
Public. |
DescriptionMove preferred scrollbar style preference change listening from renderer to browser, 1 of 3.
This first part just addds a new parameter (via method overloading to keep
compatibility) that will be sent in an IPC from the browser.
BUG=306348
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165560
Patch Set 1 #Patch Set 2 : Define enum #
Messages
Total messages: 16 (0 generated)
Is there a better type than 'int' we could use? What are the possible values and meanings of those value? To unsubscribe from this group and stop receiving emails from it, send an email to blink-reviews+unsubscribe@chromium.org.
On 2014/01/17 21:44:36, jamesr wrote: > Is there a better type than 'int' we could use? What are the possible > values and meanings of those value? > > To unsubscribe from this group and stop receiving emails from it, send an email > to mailto:blink-reviews+unsubscribe@chromium.org. The system defines NSScrollerStyle enum to be NSInteger, but only on 10.7+. We forward-declare it here: https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit... The problem is that NSInteger is defined in system headers that contain ObjC, so I can't pull in the definition for it if this file is transitively included into a .cpp/.cc file (and it is). The same will be true for the IPC message parameter.
I'm going to defer to jamesr here.
James, PTAL. I defined an enum in the blink public headers that I'll use across IPC as well with IPC_ENUM_TRAITS_MAX_VALUE.
lgtm
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsesek@chromium.org/142033003/90001
Message was sent while issue was closed.
Change committed as 165560
Message was sent while issue was closed.
I'm getting ../../third_party/WebKit/Source/web/mac/WebScrollbarTheme.cpp:41:39: error: use of undeclared identifier 'NSScrollerStyleLegacy'; did you mean 'ScrollerStyleLegacy'? COMPILE_ASSERT(ScrollerStyleLegacy == NSScrollerStyleLegacy, ScrollerStyle_Legacy_must_be_equal); ^~~~~~~~~~~~~~~~~~~~~ ScrollerStyleLegacy Is this missing an include?
Message was sent while issue was closed.
On 2014/01/23 17:49:30, Nico wrote: > I'm getting > > ../../third_party/WebKit/Source/web/mac/WebScrollbarTheme.cpp:41:39: error: use > of undeclared identifier 'NSScrollerStyleLegacy'; did you mean > 'ScrollerStyleLegacy'? > COMPILE_ASSERT(ScrollerStyleLegacy == NSScrollerStyleLegacy, > ScrollerStyle_Legacy_must_be_equal); > ^~~~~~~~~~~~~~~~~~~~~ > ScrollerStyleLegacy > > Is this missing an include? SDK version issue. I'm going to fix it in part 3 by moving Theme.cpp to Theme.mm.
Message was sent while issue was closed.
On 2014/01/23 17:50:03, rsesek wrote: > On 2014/01/23 17:49:30, Nico wrote: > > I'm getting > > > > ../../third_party/WebKit/Source/web/mac/WebScrollbarTheme.cpp:41:39: error: > use > > of undeclared identifier 'NSScrollerStyleLegacy'; did you mean > > 'ScrollerStyleLegacy'? > > COMPILE_ASSERT(ScrollerStyleLegacy == NSScrollerStyleLegacy, > > ScrollerStyle_Legacy_must_be_equal); > > ^~~~~~~~~~~~~~~~~~~~~ > > ScrollerStyleLegacy > > > > Is this missing an include? > > SDK version issue. I'm going to fix it in part 3 by moving Theme.cpp to > Theme.mm. Which SDK should be installed then?
Message was sent while issue was closed.
On 2014/01/23 17:54:27, Tommy Widenflycht wrote: > On 2014/01/23 17:50:03, rsesek wrote: > > On 2014/01/23 17:49:30, Nico wrote: > > > I'm getting > > > > > > ../../third_party/WebKit/Source/web/mac/WebScrollbarTheme.cpp:41:39: error: > > use > > > of undeclared identifier 'NSScrollerStyleLegacy'; did you mean > > > 'ScrollerStyleLegacy'? > > > COMPILE_ASSERT(ScrollerStyleLegacy == NSScrollerStyleLegacy, > > > ScrollerStyle_Legacy_must_be_equal); > > > ^~~~~~~~~~~~~~~~~~~~~ > > > ScrollerStyleLegacy > > > > > > Is this missing an include? > > > > SDK version issue. I'm going to fix it in part 3 by moving Theme.cpp to > > Theme.mm. > > Which SDK should be installed then? 10.6 is the one we build against.
But we support building with newer sdks for devs. I'll comment out this assert for now. On Thu, Jan 23, 2014 at 9:54 AM, <rsesek@chromium.org> wrote: > On 2014/01/23 17:54:27, Tommy Widenflycht wrote: > >> On 2014/01/23 17:50:03, rsesek wrote: >> > On 2014/01/23 17:49:30, Nico wrote: >> > > I'm getting >> > > >> > > ../../third_party/WebKit/Source/web/mac/WebScrollbarTheme.cpp:41:39: >> > error: > >> > use >> > > of undeclared identifier 'NSScrollerStyleLegacy'; did you mean >> > > 'ScrollerStyleLegacy'? >> > > COMPILE_ASSERT(ScrollerStyleLegacy == NSScrollerStyleLegacy, >> > > ScrollerStyle_Legacy_must_be_equal); >> > > ^~~~~~~~~~~~~~~~~~~~~ >> > > ScrollerStyleLegacy >> > > >> > > Is this missing an include? >> > >> > SDK version issue. I'm going to fix it in part 3 by moving Theme.cpp to >> > Theme.mm. >> > > Which SDK should be installed then? >> > > 10.6 is the one we build against. > > https://codereview.chromium.org/142033003/ > To unsubscribe from this group and stop receiving emails from it, send an email to blink-reviews+unsubscribe@chromium.org.
Message was sent while issue was closed.
On 2014/01/23 17:57:23, Nico wrote: > But we support building with newer sdks for devs. I think you meant, "We have a script that silently selects newer SDKs that apparently isn't tested anywhere"? :)
On Thu, Jan 23, 2014 at 9:58 AM, <rsesek@chromium.org> wrote: > On 2014/01/23 17:57:23, Nico wrote: > >> But we support building with newer sdks for devs. >> > > I think you meant, "We have a script that silently selects newer SDKs that > apparently isn't tested anywhere"? :) > "Supported" in "this is almost never broken, is tested by almost all devs, and people who break it get beat with a large trout". > > https://codereview.chromium.org/142033003/ > To unsubscribe from this group and stop receiving emails from it, send an email to blink-reviews+unsubscribe@chromium.org.
Commented this out in r165650 On Thu, Jan 23, 2014 at 9:59 AM, Nico Weber <thakis@chromium.org> wrote: > On Thu, Jan 23, 2014 at 9:58 AM, <rsesek@chromium.org> wrote: > >> On 2014/01/23 17:57:23, Nico wrote: >> >>> But we support building with newer sdks for devs. >>> >> >> I think you meant, "We have a script that silently selects newer SDKs that >> apparently isn't tested anywhere"? :) >> > > "Supported" in "this is almost never broken, is tested by almost all devs, > and people who break it get beat with a large trout". > > >> >> https://codereview.chromium.org/142033003/ >> > > To unsubscribe from this group and stop receiving emails from it, send an email to blink-reviews+unsubscribe@chromium.org. |