Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 142033003: Move preferred scrollbar style preference change listening from renderer to browser, 1 of 3. (Closed)

Created:
6 years, 11 months ago by Robert Sesek
Modified:
6 years, 11 months ago
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium, ccameron
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Move preferred scrollbar style preference change listening from renderer to browser, 1 of 3. This first part just addds a new parameter (via method overloading to keep compatibility) that will be sent in an IPC from the browser. BUG=306348 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165560

Patch Set 1 #

Patch Set 2 : Define enum #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -0 lines) Patch
M Source/web/mac/WebScrollbarTheme.cpp View 1 2 chunks +12 lines, -0 lines 0 comments Download
M public/web/mac/WebScrollbarTheme.h View 1 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
Robert Sesek
Part 2: https://codereview.chromium.org/136443008/ Part 3: https://codereview.chromium.org/136333009/
6 years, 11 months ago (2014-01-17 21:35:31 UTC) #1
jamesr
Is there a better type than 'int' we could use? What are the possible values ...
6 years, 11 months ago (2014-01-17 21:44:36 UTC) #2
Robert Sesek
On 2014/01/17 21:44:36, jamesr wrote: > Is there a better type than 'int' we could ...
6 years, 11 months ago (2014-01-17 21:49:14 UTC) #3
abarth-chromium
I'm going to defer to jamesr here.
6 years, 11 months ago (2014-01-18 09:00:36 UTC) #4
Robert Sesek
James, PTAL. I defined an enum in the blink public headers that I'll use across ...
6 years, 11 months ago (2014-01-22 14:56:13 UTC) #5
jamesr
lgtm
6 years, 11 months ago (2014-01-22 19:07:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsesek@chromium.org/142033003/90001
6 years, 11 months ago (2014-01-22 19:08:44 UTC) #7
commit-bot: I haz the power
Change committed as 165560
6 years, 11 months ago (2014-01-22 22:45:28 UTC) #8
Nico
I'm getting ../../third_party/WebKit/Source/web/mac/WebScrollbarTheme.cpp:41:39: error: use of undeclared identifier 'NSScrollerStyleLegacy'; did you mean 'ScrollerStyleLegacy'? COMPILE_ASSERT(ScrollerStyleLegacy == ...
6 years, 11 months ago (2014-01-23 17:49:30 UTC) #9
Robert Sesek
On 2014/01/23 17:49:30, Nico wrote: > I'm getting > > ../../third_party/WebKit/Source/web/mac/WebScrollbarTheme.cpp:41:39: error: use > of ...
6 years, 11 months ago (2014-01-23 17:50:03 UTC) #10
Tommy Widenflycht
On 2014/01/23 17:50:03, rsesek wrote: > On 2014/01/23 17:49:30, Nico wrote: > > I'm getting ...
6 years, 11 months ago (2014-01-23 17:54:27 UTC) #11
Robert Sesek
On 2014/01/23 17:54:27, Tommy Widenflycht wrote: > On 2014/01/23 17:50:03, rsesek wrote: > > On ...
6 years, 11 months ago (2014-01-23 17:54:48 UTC) #12
Nico
But we support building with newer sdks for devs. I'll comment out this assert for ...
6 years, 11 months ago (2014-01-23 17:57:23 UTC) #13
Robert Sesek
On 2014/01/23 17:57:23, Nico wrote: > But we support building with newer sdks for devs. ...
6 years, 11 months ago (2014-01-23 17:58:27 UTC) #14
Nico
On Thu, Jan 23, 2014 at 9:58 AM, <rsesek@chromium.org> wrote: > On 2014/01/23 17:57:23, Nico ...
6 years, 11 months ago (2014-01-23 17:59:27 UTC) #15
Nico
6 years, 11 months ago (2014-01-23 18:08:28 UTC) #16
Commented this out in r165650


On Thu, Jan 23, 2014 at 9:59 AM, Nico Weber <thakis@chromium.org> wrote:

> On Thu, Jan 23, 2014 at 9:58 AM, <rsesek@chromium.org> wrote:
>
>> On 2014/01/23 17:57:23, Nico wrote:
>>
>>> But we support building with newer sdks for devs.
>>>
>>
>> I think you meant, "We have a script that silently selects newer SDKs that
>> apparently isn't tested anywhere"? :)
>>
>
> "Supported" in "this is almost never broken, is tested by almost all devs,
> and people who break it get beat with a large trout".
>
>
>>
>> https://codereview.chromium.org/142033003/
>>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698