Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1557)

Issue 1420273004: Add FILES.cfg for Mandoline build archiving. (Closed)

Created:
5 years, 2 months ago by msw
Modified:
5 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews, penghuang+watch-mandoline_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add FILES.cfg for Mandoline build archiving. Use a modified format of chrome/tools/build/win/FILES.cfg Specify paths with applicable platforms and directory flags. Lists minimal binaries needed to open google.com locally. BUG=541265 TEST=None, will be used by https://codereview.chromium.org/1412173008 R=sky@chromium.org Committed: https://crrev.com/54b65d680437597fb9d06b17ab9bbcf0f33931d6 Cr-Commit-Position: refs/heads/master@{#356186}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Simplify tags, add platform and dir; add android and linux files. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -0 lines) Patch
A mandoline/tools/data/FILES.cfg View 1 1 chunk +58 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
msw
Hey Scott, please take a look; thanks!
5 years, 2 months ago (2015-10-24 00:05:36 UTC) #2
sky
https://codereview.chromium.org/1420273004/diff/1/mandoline/tools/data/FILES.cfg File mandoline/tools/data/FILES.cfg (right): https://codereview.chromium.org/1420273004/diff/1/mandoline/tools/data/FILES.cfg#newcode4 mandoline/tools/data/FILES.cfg:4: # Copyright (c) 2015 The Chromium Authors. All rights ...
5 years, 2 months ago (2015-10-24 02:15:17 UTC) #3
msw
Done. Please take another look; thanks! https://codereview.chromium.org/1420273004/diff/1/mandoline/tools/data/FILES.cfg File mandoline/tools/data/FILES.cfg (right): https://codereview.chromium.org/1420273004/diff/1/mandoline/tools/data/FILES.cfg#newcode4 mandoline/tools/data/FILES.cfg:4: # Copyright (c) ...
5 years, 1 month ago (2015-10-26 23:19:44 UTC) #6
sky
LGTM
5 years, 1 month ago (2015-10-26 23:28:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1420273004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1420273004/40001
5 years, 1 month ago (2015-10-26 23:34:02 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 1 month ago (2015-10-26 23:49:21 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-10-26 23:51:06 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/54b65d680437597fb9d06b17ab9bbcf0f33931d6
Cr-Commit-Position: refs/heads/master@{#356186}

Powered by Google App Engine
This is Rietveld 408576698