Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(667)

Issue 1412173008: Add simple build archiving for Mandoline binaries. (Closed)

Created:
5 years, 2 months ago by msw
Modified:
5 years, 1 month ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org, stip+watch_chromium.org, iannucci
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Add simple build archiving for Mandoline binaries. Depends on https://codereview.chromium.org/1420273004 Exec the FILES.cfg to get the list of paths needed. Upload each applicable path to a versioned GS directory. TODO: Avoid exec()? Extend api.chromium.archive_build? BUG=541265 TEST=Chromium Mojo FYI bots upload good daily binaries. R=dpranke@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=297309

Patch Set 1 #

Patch Set 2 : Use api.file.read and exec() instead of execfile for test_data. #

Messages

Total messages: 9 (5 generated)
msw
Hey Dirk, please take a look; thanks! +CC Robbie.
5 years, 1 month ago (2015-10-26 23:21:29 UTC) #5
Dirk Pranke
lgtm
5 years, 1 month ago (2015-10-26 23:26:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412173008/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412173008/20001
5 years, 1 month ago (2015-10-26 23:52:44 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-10-26 23:56:32 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=297309

Powered by Google App Engine
This is Rietveld 408576698