Issue 1420173006: Move resolving of natives to a late stage (during code emission). That eliminates unnecessary nativ…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1420173006: Move resolving of natives to a late stage (during code emission). That eliminates unnecessary nativ… (Closed)

Created:
5 years, 1 month ago by srdjan

Modified:
5 years, 1 month ago

Reviewers:
hausner

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Move resolving of natives to a late stage (during code emission). That eliminates unnecessary native resolution (e.g., when native gets recognized or rejected in the inliner). Removed tests that are now impossible to implement with AST (fake native functions). BUG= R=hausner@google.com Committed: https://github.com/dart-lang/sdk/commit/181e8cc2a9b8044e91ee4d7ab1d4e0aaa4fe64bf

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+58 lines, -244 lines)			Patch
M	runtime/vm/ast.h	View		3 chunks	+0 lines, -9 lines	0 comments	Download
M	runtime/vm/code_generator_test.cc	View		2 chunks	+0 lines, -205 lines	0 comments	Download
M	runtime/vm/compiler.cc	View		2 chunks	+7 lines, -2 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View		3 chunks	+15 lines, -3 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View		2 chunks	+25 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	runtime/vm/intermediate_language_arm64.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language_mips.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/vm/native_entry.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/parser.cc	View	1	1 chunk	+1 line, -20 lines	0 comments	Download

Total messages: 4 (1 generated)

srdjan

5 years, 1 month ago (2015-11-04 00:18:46 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
181e8cc2a9b8044e91ee4d7ab1d4e0aaa4fe64bf (presubmit successful).