runtime/vm/native_entry.cc - Issue 1420173006: Move resolving of natives to a late stage (during code emission). That eliminates unnecessary nativ…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/native_entry.cc

Issue 1420173006: Move resolving of natives to a late stage (during code emission). That eliminates unnecessary nativ… (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: r Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/native_entry.cc

diff --git a/runtime/vm/native_entry.cc b/runtime/vm/native_entry.cc

index 5d5a59685cd330f85db371dabc6ad0b00c1bf5ba..63c9a61a185036241fb5689ec9cf3bfcc2f6b938 100644

--- a/runtime/vm/native_entry.cc

+++ b/runtime/vm/native_entry.cc

@@ -234,7 +234,7 @@ void NativeEntry::LinkNativeCall(Dart_NativeArguments args) {

const intptr_t argc_tag = NativeArguments::ComputeArgcTag(func);

const bool is_leaf_call =

- (argc_tag & NativeArguments::AutoSetupScopeMask()) == 0;

+ (argc_tag & NativeArguments::AutoSetupScopeMask()) == 0;

call_through_wrapper = !is_bootstrap_native && !is_leaf_call;

« no previous file with comments | « runtime/vm/intermediate_language_x64.cc ('k') | runtime/vm/parser.cc » ('j') | no next file with comments »