Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: runtime/vm/ast.h

Issue 1420173006: Move resolving of natives to a late stage (during code emission). That eliminates unnecessary nativ… (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: r Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/code_generator_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/ast.h
diff --git a/runtime/vm/ast.h b/runtime/vm/ast.h
index c3b6ac1f6f81bf532050930b232343988eda527a..14934fd3cefa0b997519cf20d379679f05e93a2e 100644
--- a/runtime/vm/ast.h
+++ b/runtime/vm/ast.h
@@ -1814,19 +1814,14 @@ class NativeBodyNode : public AstNode {
NativeBodyNode(intptr_t token_pos,
const Function& function,
const String& native_c_function_name,
- NativeFunction native_c_function,
LocalScope* scope,
- bool is_bootstrap_native,
bool link_lazily = false)
: AstNode(token_pos),
function_(function),
native_c_function_name_(native_c_function_name),
- native_c_function_(native_c_function),
scope_(scope),
- is_bootstrap_native_(is_bootstrap_native),
link_lazily_(link_lazily) {
ASSERT(function_.IsZoneHandle());
- ASSERT(native_c_function_ != NULL);
ASSERT(native_c_function_name_.IsZoneHandle());
ASSERT(native_c_function_name_.IsSymbol());
}
@@ -1835,9 +1830,7 @@ class NativeBodyNode : public AstNode {
const String& native_c_function_name() const {
return native_c_function_name_;
}
- NativeFunction native_c_function() const { return native_c_function_; }
LocalScope* scope() const { return scope_; }
- bool is_bootstrap_native() const { return is_bootstrap_native_; }
bool link_lazily() const { return link_lazily_; }
@@ -1848,9 +1841,7 @@ class NativeBodyNode : public AstNode {
private:
const Function& function_; // Native Dart function.
const String& native_c_function_name_;
- NativeFunction native_c_function_; // Actual non-Dart implementation.
LocalScope* scope_;
- const bool is_bootstrap_native_; // Is a bootstrap native method.
const bool link_lazily_;
DISALLOW_IMPLICIT_CONSTRUCTORS(NativeBodyNode);
« no previous file with comments | « no previous file | runtime/vm/code_generator_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698