Make BRD take advantage of zero initialized memory

Make BRD take advantage of zero initialized memory

This is the third step in a three part change:
(1) Skia: Add SkBRDAllocator.
(2) Android: Make JavaPixelAllocator and RecyclingClippingPixelAllocator
             implement SkBRDAllocator.
(3) Skia: Change SkBitmapRegionDecoder to use SkBRDAllocator and take
          advantage of zero allocated memory when possible.

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/cb8d719d7a991ceb93ccc7dd1542bb0cd82437d6

[scroggo, 2015-11-10 22:31:14]

scroggo@google.com changed reviewers:
+ scroggo@google.com

[scroggo, 2015-11-10 22:31:14]

Other than a variable with larger scope than it needs, lgtm

https://codereview.chromium.org/1420053010/diff/20001/tools/codec/SkBitmapReg...
File tools/codec/SkBitmapRegionCanvas.cpp (right):

https://codereview.chromium.org/1420053010/diff/20001/tools/codec/SkBitmapReg...
tools/codec/SkBitmapRegionCanvas.cpp:105: SkCodec::ZeroInitialized zeroInit =
allocator ? allocator->zeroInit() :
It looks like we only care about the variable zeroInit inside the if statement.
how about the following:

if (SubsetType::kPartiallyInside_SubsetType == type) {
  zeroInit = ...
  if (no_zeroInit == zeroInit) {
    bitmap->eraseColor(0);
  }
}

[msarett, 2015-11-10 22:50:00]

I'm impressed.  I think you reviewed this before I published it :).

https://codereview.chromium.org/1420053010/diff/20001/tools/codec/SkBitmapReg...
File tools/codec/SkBitmapRegionCanvas.cpp (right):

https://codereview.chromium.org/1420053010/diff/20001/tools/codec/SkBitmapReg...
tools/codec/SkBitmapRegionCanvas.cpp:105: SkCodec::ZeroInitialized zeroInit =
allocator ? allocator->zeroInit() :
On 2015/11/10 22:31:14, scroggo wrote:
> It looks like we only care about the variable zeroInit inside the if
statement.
> how about the following:
> 
> if (SubsetType::kPartiallyInside_SubsetType == type) {
>   zeroInit = ...
>   if (no_zeroInit == zeroInit) {
>     bitmap->eraseColor(0);
>   }
> }

Done.

[scroggo, 2015-11-10 22:56:37]

On 2015/11/10 22:50:00, msarett wrote:
> I'm impressed.  I think you reviewed this before I published it :).

codereview told me this depended on the other one. I wanted to take a look at
how that one was used before approving it. No surprises, though. lgtm
> 
>
https://codereview.chromium.org/1420053010/diff/20001/tools/codec/SkBitmapReg...
> File tools/codec/SkBitmapRegionCanvas.cpp (right):
> 
>
https://codereview.chromium.org/1420053010/diff/20001/tools/codec/SkBitmapReg...
> tools/codec/SkBitmapRegionCanvas.cpp:105: SkCodec::ZeroInitialized zeroInit =
> allocator ? allocator->zeroInit() :
> On 2015/11/10 22:31:14, scroggo wrote:
> > It looks like we only care about the variable zeroInit inside the if
> statement.
> > how about the following:
> > 
> > if (SubsetType::kPartiallyInside_SubsetType == type) {
> >   zeroInit = ...
> >   if (no_zeroInit == zeroInit) {
> >     bitmap->eraseColor(0);
> >   }
> > }
> 
> Done.

[msarett, 2015-11-11 21:19:58]

The CQ bit was checked by msarett@google.com

[commit-bot: I haz the power, 2015-11-11 21:20:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1420053010/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1420053010/40001

[commit-bot: I haz the power, 2015-11-11 21:30:55]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/cb8d719d7a991ceb93ccc7dd1542bb0cd82437d6