Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1423253004: Add an Allocator interface that indicates if memory is zero init (Closed)

Created:
5 years, 1 month ago by msarett
Modified:
5 years, 1 month ago
Reviewers:
scroggo
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@folder
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add an Allocator interface that indicates if memory is zero init This is the first step in a three part change: (1) Skia: Add SkBRDAllocator. (2) Android: Make JavaPixelAllocator and RecyclingClippingPixelAllocator implement SkBRDAllocator. (3) Skia: Change SkBitmapRegionDecoder to use SkBRDAllocator and take advantage of zero allocated memory when possible. BUG=skia: Committed: https://skia.googlesource.com/skia/+/49115b57cb9d260ddd49a6905ee87af63b3ab066

Patch Set 1 #

Patch Set 2 : Use SkCodec::ZeroInitialized instead of a bool #

Patch Set 3 : zeroInit() instead of isZeroInit()? #

Patch Set 4 : Make this const #

Patch Set 5 : Rebase on new folder #

Total comments: 2

Patch Set 6 : Rebase #

Patch Set 7 : Remove unnecessary declaration #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
A tools/android/SkBRDAllocator.h View 1 2 3 4 5 6 1 chunk +24 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 1417393004 Patch 40001

Dependent Patchsets:

Issue 1420053010 Patch 40001

Messages

Total messages: 8 (2 generated)
msarett
5 years, 1 month ago (2015-11-10 17:31:09 UTC) #2
scroggo
https://codereview.chromium.org/1423253004/diff/80001/tools/codec/SkBRDAllocator.h File tools/codec/SkBRDAllocator.h (right): https://codereview.chromium.org/1423253004/diff/80001/tools/codec/SkBRDAllocator.h#newcode18 tools/codec/SkBRDAllocator.h:18: virtual bool allocPixelRef(SkBitmap*, SkColorTable*) = 0; This does not ...
5 years, 1 month ago (2015-11-10 22:31:52 UTC) #3
msarett
https://codereview.chromium.org/1423253004/diff/80001/tools/codec/SkBRDAllocator.h File tools/codec/SkBRDAllocator.h (right): https://codereview.chromium.org/1423253004/diff/80001/tools/codec/SkBRDAllocator.h#newcode18 tools/codec/SkBRDAllocator.h:18: virtual bool allocPixelRef(SkBitmap*, SkColorTable*) = 0; On 2015/11/10 22:31:52, ...
5 years, 1 month ago (2015-11-10 22:45:25 UTC) #4
scroggo
lgtm
5 years, 1 month ago (2015-11-10 22:50:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1423253004/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1423253004/120001
5 years, 1 month ago (2015-11-11 14:10:31 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-11 14:21:32 UTC) #8
Message was sent while issue was closed. 
Committed patchset #7 (id:120001) as
https://skia.googlesource.com/skia/+/49115b57cb9d260ddd49a6905ee87af63b3ab066

Powered by Google App Engine
This is Rietveld 408576698