Subzero: Refactor x86 register definitions to use the alias mechanism.

src/IceConditionCodesX8632.h

Index: src/IceConditionCodesX8632.h
diff --git a/src/IceConditionCodesX8632.h b/src/IceConditionCodesX8632.h
index eb09687a9a8669bf338e34d0a12061dc0df8ecdd..e17bf695acc4c66b2f3fb2506a8defb75cd8bf70 100644
--- a/src/IceConditionCodesX8632.h
+++ b/src/IceConditionCodesX8632.h
@@ -29,7 +29,7 @@ public:
   /// An enum of condition codes used for branches and cmov. The enum value
   /// should match the value used to encode operands in binary instructions.
   enum BrCond {
-#define X(tag, encode, opp, dump, emit) tag encode,

[John, 2015/10/28 12:48:06]

Not that it matters, but I think tag was more clear. OK as is, though.

[Jim Stichnoth, 2015/10/28 14:03:55]

I was trying to make all the x-macros consistent with "val" meaning "enum
value".

+#define X(val, encode, opp, dump, emit) val = encode,
     ICEINSTX8632BR_TABLE
 #undef X
         Br_None
@@ -39,7 +39,7 @@ public:
   /// value should match the value used to encode operands in binary
   /// instructions.
   enum CmppsCond {
-#define X(tag, emit) tag,
+#define X(val, emit) val,
     ICEINSTX8632CMPPS_TABLE
 #undef X
         Cmpps_Invalid