Subzero: Refactor x86 register definitions to use the alias mechanism.

src/IceAssemblerX86Base.h

Index: src/IceAssemblerX86Base.h
diff --git a/src/IceAssemblerX86Base.h b/src/IceAssemblerX86Base.h
index a7db6efb5f3fe6005575c9f206a0baaed54c8142..a194224b89d66554b2bd8ecec68408b6d5e8d05e 100644
--- a/src/IceAssemblerX86Base.h
+++ b/src/IceAssemblerX86Base.h
@@ -115,9 +115,8 @@ template <class Machine> class AssemblerX86Base : public Assembler {
   AssemblerX86Base &operator=(const AssemblerX86Base &) = delete;
 
 protected:
-  AssemblerX86Base(AssemblerKind Kind, GlobalContext *Ctx,
-                   bool use_far_branches)
-      : Assembler(Kind, Ctx) {
+  AssemblerX86Base(AssemblerKind Kind, bool use_far_branches)
+      : Assembler(Kind) {
     // This mode is only needed and implemented for MIPS and ARM.
     assert(!use_far_branches);
     (void)use_far_branches;
@@ -954,8 +953,6 @@ private:
   bool is8BitRegisterRequiringRex(const Type Ty, const RegType Reg) {
     static constexpr bool IsGPR =
         std::is_same<typename std::decay<RegType>::type,
-                     typename Traits::ByteRegister>::value ||

[John, 2015/10/28 12:48:06]

you need to revive this

[Jim Stichnoth, 2015/10/28 14:03:55]

Done.  </shamecube>

-        std::is_same<typename std::decay<RegType>::type,
                      typename Traits::GPRRegister>::value;
 
     return IsGPR && (Reg & 0x04) != 0 && (Reg & 0x08) == 0 &&