Subzero: Refactor x86 register definitions to use the alias mechanism.

src/IceConditionCodesX8632.h

 //===- subzero/src/IceConditionCodesX8632.h - Condition Codes ---*- C++ -*-===//
 //
 //                        The Subzero Code Generator
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 ///
 /// \file
@@ skipping 11 matching lines @@
 
 class CondX86 {
   CondX86() = delete;
   CondX86(const CondX86 &) = delete;
   CondX86 &operator=(const CondX86 &) = delete;
 
 public:
   /// An enum of condition codes used for branches and cmov. The enum value
   /// should match the value used to encode operands in binary instructions.
   enum BrCond {
-#define X(tag, encode, opp, dump, emit) tag encode,

[John, 2015/10/28 12:48:06]

Not that it matters, but I think tag was more clear. OK as is, though.

[Jim Stichnoth, 2015/10/28 14:03:55]

I was trying to make all the x-macros consistent with "val" meaning "enum
value".

+#define X(val, encode, opp, dump, emit) val = encode,
     ICEINSTX8632BR_TABLE
 #undef X
         Br_None
   };
 
   /// An enum of condition codes relevant to the CMPPS instruction. The enum
   /// value should match the value used to encode operands in binary
   /// instructions.
   enum CmppsCond {
-#define X(tag, emit) tag,
+#define X(val, emit) val,
     ICEINSTX8632CMPPS_TABLE
 #undef X
         Cmpps_Invalid
   };
 };
 
 } // end of namespace Ice
 
 #endif // SUBZERO_SRC_ICECONDITIONCODESX8632_H