Implement flag and source getters on RegExp.prototype.

Implement flag and source getters on RegExp.prototype.

R=littledan@chromium.org
BUG=v8:3715, v8:4528
LOG=Y

Committed: https://crrev.com/60e8877e161fe6175e19fafce2d6ed1c3999cdb1
Cr-Commit-Position: refs/heads/master@{#31753}

Committed: https://crrev.com/b5c80a31ad266eb38a0cf2ff756be59c66d34aa5
Cr-Commit-Position: refs/heads/master@{#31773}

Committed: https://crrev.com/85494e90bb63a3a9e19a1bf862cb6bfcb0162ee9
Cr-Commit-Position: refs/heads/master@{#31782}

Committed: https://crrev.com/152163c1646b45f5fc5d31a4ec2eb55d7f4a2ffc
Cr-Commit-Position: refs/heads/master@{#31804}

Committed: https://crrev.com/2237ba0dba22841e29e2fba877f4f9cd0f23eff7
Cr-Commit-Position: refs/heads/master@{#31824}

[Yang, 2015-10-30 13:29:11]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-30 13:29:16]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1419823010/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1419823010/1

[commit-bot: I haz the power, 2015-10-30 14:10:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-30 14:10:32]

Dry run: Try jobs failed on following builders:
  v8_win64_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel/builds/10258)

[Yang, 2015-10-30 14:19:51]

Patchset #2 (id:20001) has been deleted

[Yang, 2015-10-30 14:20:21]

yangguo@chromium.org changed reviewers:
+ ulan@chromium.org

[Yang, 2015-10-30 14:20:22]

Ulan, please take a look at the heap changes.

[Yang, 2015-10-30 14:21:02]

yangguo@chromium.org changed reviewers:
+ jochen@chromium.org

[Yang, 2015-10-30 14:21:02]

Jochen, please look at the changes to src/include

[Yang, 2015-10-30 14:21:08]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-30 14:22:34]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1419823010/2
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1419823010/2

[jochen (gone - plz use gerrit), 2015-10-30 14:23:08]

lgtm

[commit-bot: I haz the power, 2015-10-30 15:36:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-30 15:36:54]

Dry run: This issue passed the CQ dry run.

[Yang, 2015-11-02 10:27:14]

On 2015/10/30 15:36:54, commit-bot: I haz the power wrote:
> Dry run: This issue passed the CQ dry run.

Dan, ping, please take a look.

[Dan Ehrenberg, 2015-11-02 19:21:06]

Looks good, just a couple nits.

https://codereview.chromium.org/1419823010/diff/2/src/js/macros.py
File src/js/macros.py (right):

https://codereview.chromium.org/1419823010/diff/2/src/js/macros.py#newcode181
src/js/macros.py:181: macro REGEXP_GLOBAL(regexp) = (regexp[regExpFlagsSymbol] &
1);
Can you define constants for these numbers like 1, 2, 4, etc?

https://codereview.chromium.org/1419823010/diff/2/test/mjsunit/regexp.js
File test/mjsunit/regexp.js (left):

https://codereview.chromium.org/1419823010/diff/2/test/mjsunit/regexp.js#oldc...
test/mjsunit/regexp.js:610: assertEquals(false, desc.configurable);
Why not leave part of this in, just to check that re doesn't have "global" and
friends as own properties?

[Yang, 2015-11-02 20:51:09]

https://codereview.chromium.org/1419823010/diff/2/src/js/macros.py
File src/js/macros.py (right):

https://codereview.chromium.org/1419823010/diff/2/src/js/macros.py#newcode181
src/js/macros.py:181: macro REGEXP_GLOBAL(regexp) = (regexp[regExpFlagsSymbol] &
1);
On 2015/11/02 19:21:06, Dan Ehrenberg wrote:
> Can you define constants for these numbers like 1, 2, 4, etc?

Isnt the point of macros.py to contain those constants that are otherwise
hidden? See those date macros below. I dont think adding another level of
indirection is going to make this more readable. The macro names are descriptive
enough.

[Dan Ehrenberg, 2015-11-02 20:59:21]

On 2015/11/02 at 20:51:09, yangguo wrote:
> https://codereview.chromium.org/1419823010/diff/2/src/js/macros.py
> File src/js/macros.py (right):
> 
> https://codereview.chromium.org/1419823010/diff/2/src/js/macros.py#newcode181
> src/js/macros.py:181: macro REGEXP_GLOBAL(regexp) = (regexp[regExpFlagsSymbol]
& 1);
> On 2015/11/02 19:21:06, Dan Ehrenberg wrote:
> > Can you define constants for these numbers like 1, 2, 4, etc?
> 
> Isnt the point of macros.py to contain those constants that are otherwise
hidden? See those date macros below. I dont think adding another level of
indirection is going to make this more readable. The macro names are descriptive
enough.

You seem to have the constants in two places--in those REGEXP_GLOBAL things, and
also in the getter definitions, e.g., line 391 of src/js/regexp.js. These need
to be kept in sync to work correctly. That's why I think there should be a
constant in macros.py to hold those constants.

[Yang, 2015-11-03 07:48:06]

On 2015/11/02 20:59:21, Dan Ehrenberg wrote:
> On 2015/11/02 at 20:51:09, yangguo wrote:
> > https://codereview.chromium.org/1419823010/diff/2/src/js/macros.py
> > File src/js/macros.py (right):
> > 
> >
https://codereview.chromium.org/1419823010/diff/2/src/js/macros.py#newcode181
> > src/js/macros.py:181: macro REGEXP_GLOBAL(regexp) =
(regexp[regExpFlagsSymbol]
> & 1);
> > On 2015/11/02 19:21:06, Dan Ehrenberg wrote:
> > > Can you define constants for these numbers like 1, 2, 4, etc?
> > 
> > Isnt the point of macros.py to contain those constants that are otherwise
> hidden? See those date macros below. I dont think adding another level of
> indirection is going to make this more readable. The macro names are
descriptive
> enough.
> 
> You seem to have the constants in two places--in those REGEXP_GLOBAL things,
and
> also in the getter definitions, e.g., line 391 of src/js/regexp.js. These need
> to be kept in sync to work correctly. That's why I think there should be a
> constant in macros.py to hold those constants.

Addressed comments.

[Yang, 2015-11-03 07:48:12]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-03 07:48:24]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1419823010/50001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1419823010/50001

[commit-bot: I haz the power, 2015-11-03 08:11:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-03 08:11:54]

Dry run: This issue passed the CQ dry run.

[Dan Ehrenberg, 2015-11-03 15:45:58]

lgtm

[Dan Ehrenberg, 2015-11-03 15:46:02]

lgtm

[Yang, 2015-11-03 16:15:23]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2015-11-03 16:15:23]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/1419823010/#ps50001
(title: "addressed comments")

[commit-bot: I haz the power, 2015-11-03 16:15:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1419823010/50001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1419823010/50001

[commit-bot: I haz the power, 2015-11-03 16:17:01]

Committed patchset #3 (id:50001)

[commit-bot: I haz the power, 2015-11-03 16:17:13]

Patchset 3 (id:??) landed as
https://crrev.com/60e8877e161fe6175e19fafce2d6ed1c3999cdb1
Cr-Commit-Position: refs/heads/master@{#31753}

[Michael Achenbach, 2015-11-03 17:27:31]

A revert of this CL (patchset #3 id:50001) has been created in
https://codereview.chromium.org/1427733005/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] Changes layout tests. Please rebase
upstream first. E.g.:
http://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/buil....

[Yang, 2015-11-04 07:24:20]

Description was changed from

==========
Implement flag and source getters on RegExp.prototype.

R=littledan@chromium.org
BUG=v8:3715, v8:4528
LOG=Y

Committed: https://crrev.com/60e8877e161fe6175e19fafce2d6ed1c3999cdb1
Cr-Commit-Position: refs/heads/master@{#31753}
==========

to

==========
Implement flag and source getters on RegExp.prototype.

R=littledan@chromium.org
BUG=v8:3715, v8:4528
LOG=Y

Committed: https://crrev.com/60e8877e161fe6175e19fafce2d6ed1c3999cdb1
Cr-Commit-Position: refs/heads/master@{#31753}
==========

[Yang, 2015-11-04 08:49:10]

The CQ bit was checked by yangguo@chromium.org

[commit-bot: I haz the power, 2015-11-04 08:49:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1419823010/50001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1419823010/50001

[Yang, 2015-11-04 08:54:49]

The CQ bit was unchecked by yangguo@chromium.org

[Yang, 2015-11-04 08:55:07]

The CQ bit was checked by yangguo@chromium.org

[commit-bot: I haz the power, 2015-11-04 08:55:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1419823010/50001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1419823010/50001

[commit-bot: I haz the power, 2015-11-04 09:10:51]

Committed patchset #3 (id:50001)

[commit-bot: I haz the power, 2015-11-04 09:11:27]

Patchset 3 (id:??) landed as
https://crrev.com/b5c80a31ad266eb38a0cf2ff756be59c66d34aa5
Cr-Commit-Position: refs/heads/master@{#31773}

[Yang, 2015-11-04 10:57:36]

A revert of this CL (patchset #3 id:50001) has been created in
https://codereview.chromium.org/1409013006/ by yangguo@chromium.org.

The reason for reverting is: Performance issue..

[Yang, 2015-11-04 11:53:57]

Description was changed from

==========
Implement flag and source getters on RegExp.prototype.

R=littledan@chromium.org
BUG=v8:3715, v8:4528
LOG=Y

Committed: https://crrev.com/60e8877e161fe6175e19fafce2d6ed1c3999cdb1
Cr-Commit-Position: refs/heads/master@{#31753}

Committed: https://crrev.com/b5c80a31ad266eb38a0cf2ff756be59c66d34aa5
Cr-Commit-Position: refs/heads/master@{#31773}
==========

to

==========
Implement flag and source getters on RegExp.prototype.

R=littledan@chromium.org
BUG=v8:3715, v8:4528
LOG=Y

Committed: https://crrev.com/60e8877e161fe6175e19fafce2d6ed1c3999cdb1
Cr-Commit-Position: refs/heads/master@{#31753}

Committed: https://crrev.com/b5c80a31ad266eb38a0cf2ff756be59c66d34aa5
Cr-Commit-Position: refs/heads/master@{#31773}
==========

[Yang, 2015-11-04 11:54:01]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2015-11-04 11:54:02]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org,
littledan@chromium.org
Link to the patchset: https://codereview.chromium.org/1419823010/#ps70001
(title: "fix most of the perf regression")

[commit-bot: I haz the power, 2015-11-04 11:54:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1419823010/70001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1419823010/70001

[Yang, 2015-11-04 12:00:40]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2015-11-04 12:00:40]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org,
littledan@chromium.org
Link to the patchset: https://codereview.chromium.org/1419823010/#ps90001
(title: "fix")

[commit-bot: I haz the power, 2015-11-04 12:00:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1419823010/90001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1419823010/90001

[Yang, 2015-11-04 12:10:23]

The CQ bit was unchecked by yangguo@chromium.org

[Yang, 2015-11-04 12:12:46]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2015-11-04 12:12:46]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org,
littledan@chromium.org
Link to the patchset: https://codereview.chromium.org/1419823010/#ps110001
(title: "actual fix")

[commit-bot: I haz the power, 2015-11-04 12:12:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1419823010/110001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1419823010/110001

[commit-bot: I haz the power, 2015-11-04 12:28:21]

Committed patchset #6 (id:110001)

[commit-bot: I haz the power, 2015-11-04 12:28:55]

Patchset 6 (id:??) landed as
https://crrev.com/85494e90bb63a3a9e19a1bf862cb6bfcb0162ee9
Cr-Commit-Position: refs/heads/master@{#31782}

[Michael Hablich, 2015-11-04 17:56:27]

A revert of this CL (patchset #6 id:110001) has been created in
https://codereview.chromium.org/1432683002/ by hablich@chromium.org.

The reason for reverting is: Breaks Chromium tests and blocks the roll:
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_....

[Yang, 2015-11-04 19:25:23]

Description was changed from

==========
Implement flag and source getters on RegExp.prototype.

R=littledan@chromium.org
BUG=v8:3715, v8:4528
LOG=Y

Committed: https://crrev.com/60e8877e161fe6175e19fafce2d6ed1c3999cdb1
Cr-Commit-Position: refs/heads/master@{#31753}

Committed: https://crrev.com/b5c80a31ad266eb38a0cf2ff756be59c66d34aa5
Cr-Commit-Position: refs/heads/master@{#31773}

Committed: https://crrev.com/85494e90bb63a3a9e19a1bf862cb6bfcb0162ee9
Cr-Commit-Position: refs/heads/master@{#31782}
==========

to

==========
Implement flag and source getters on RegExp.prototype.

R=littledan@chromium.org
BUG=v8:3715, v8:4528
LOG=Y

Committed: https://crrev.com/60e8877e161fe6175e19fafce2d6ed1c3999cdb1
Cr-Commit-Position: refs/heads/master@{#31753}

Committed: https://crrev.com/b5c80a31ad266eb38a0cf2ff756be59c66d34aa5
Cr-Commit-Position: refs/heads/master@{#31773}

Committed: https://crrev.com/85494e90bb63a3a9e19a1bf862cb6bfcb0162ee9
Cr-Commit-Position: refs/heads/master@{#31782}
==========

[Yang, 2015-11-04 19:52:07]

On 2015/11/04 17:56:27, Hablich wrote:
> A revert of this CL (patchset #6 id:110001) has been created in
> https://codereview.chromium.org/1432683002/ by mailto:hablich@chromium.org.
> 
> The reason for reverting is: Breaks Chromium tests and blocks the roll:
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_....

Are you sure about this? I can reproduce this failure on ToT chromium even
without my patch.

[Yang, 2015-11-04 20:40:19]

The CQ bit was checked by yangguo@chromium.org

[commit-bot: I haz the power, 2015-11-04 20:40:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1419823010/110001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1419823010/110001

[Yang, 2015-11-04 20:40:41]

On 2015/11/04 19:52:07, Yang wrote:
> On 2015/11/04 17:56:27, Hablich wrote:
> > A revert of this CL (patchset #6 id:110001) has been created in
> > https://codereview.chromium.org/1432683002/ by mailto:hablich@chromium.org.
> > 
> > The reason for reverting is: Breaks Chromium tests and blocks the roll:
> >
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_....
> 
> Are you sure about this? I can reproduce this failure on ToT chromium even
> without my patch.

Yup. Seems like the breakage was entirely unrelated to V8.

[commit-bot: I haz the power, 2015-11-04 20:42:22]

Committed patchset #6 (id:110001)

[commit-bot: I haz the power, 2015-11-04 20:42:48]

Patchset 6 (id:??) landed as
https://crrev.com/152163c1646b45f5fc5d31a4ec2eb55d7f4a2ffc
Cr-Commit-Position: refs/heads/master@{#31804}

[Yang, 2015-11-05 09:07:55]

A revert of this CL (patchset #6 id:110001) has been created in
https://codereview.chromium.org/1426413002/ by yangguo@chromium.org.

The reason for reverting is: browser_tests failure with
--gtest_filter=ExternallyConnectableMessagingTest.EnablingAndDisabling.

[Yang, 2015-11-05 09:12:52]

Description was changed from

==========
Implement flag and source getters on RegExp.prototype.

R=littledan@chromium.org
BUG=v8:3715, v8:4528
LOG=Y

Committed: https://crrev.com/60e8877e161fe6175e19fafce2d6ed1c3999cdb1
Cr-Commit-Position: refs/heads/master@{#31753}

Committed: https://crrev.com/b5c80a31ad266eb38a0cf2ff756be59c66d34aa5
Cr-Commit-Position: refs/heads/master@{#31773}

Committed: https://crrev.com/85494e90bb63a3a9e19a1bf862cb6bfcb0162ee9
Cr-Commit-Position: refs/heads/master@{#31782}

Committed: https://crrev.com/152163c1646b45f5fc5d31a4ec2eb55d7f4a2ffc
Cr-Commit-Position: refs/heads/master@{#31804}
==========

to

==========
Implement flag and source getters on RegExp.prototype.

R=littledan@chromium.org
BUG=v8:3715, v8:4528
LOG=Y

Committed: https://crrev.com/60e8877e161fe6175e19fafce2d6ed1c3999cdb1
Cr-Commit-Position: refs/heads/master@{#31753}

Committed: https://crrev.com/b5c80a31ad266eb38a0cf2ff756be59c66d34aa5
Cr-Commit-Position: refs/heads/master@{#31773}

Committed: https://crrev.com/85494e90bb63a3a9e19a1bf862cb6bfcb0162ee9
Cr-Commit-Position: refs/heads/master@{#31782}

Committed: https://crrev.com/152163c1646b45f5fc5d31a4ec2eb55d7f4a2ffc
Cr-Commit-Position: refs/heads/master@{#31804}
==========

[Yang, 2015-11-05 10:35:20]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-05 10:35:28]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1419823010/150001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1419823010/150001

[commit-bot: I haz the power, 2015-11-05 10:47:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-05 10:47:52]

Dry run: Try jobs failed on following builders:
  v8_mac_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/11550)

[Yang, 2015-11-05 11:34:38]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-05 11:34:47]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1419823010/170001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1419823010/170001

[commit-bot: I haz the power, 2015-11-05 11:46:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-05 11:46:09]

Dry run: Try jobs failed on following builders:
  v8_win_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel/builds/11495)

[Yang, 2015-11-05 12:13:53]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-05 12:13:59]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1419823010/190001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1419823010/190001

[commit-bot: I haz the power, 2015-11-05 12:38:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-05 12:38:07]

Dry run: This issue passed the CQ dry run.

[Yang, 2015-11-05 13:00:31]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2015-11-05 13:00:32]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org,
littledan@chromium.org
Link to the patchset: https://codereview.chromium.org/1419823010/#ps190001
(title: "new webkit expectations")

[commit-bot: I haz the power, 2015-11-05 13:00:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1419823010/190001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1419823010/190001

[commit-bot: I haz the power, 2015-11-05 13:08:45]

Committed patchset #10 (id:190001)

[commit-bot: I haz the power, 2015-11-05 13:09:06]

Patchset 10 (id:??) landed as
https://crrev.com/2237ba0dba22841e29e2fba877f4f9cd0f23eff7
Cr-Commit-Position: refs/heads/master@{#31824}

[Igor Sheludko, 2015-11-06 19:34:33]

ishell@chromium.org changed reviewers:
+ ishell@chromium.org

[Igor Sheludko, 2015-11-06 19:34:34]

https://codereview.chromium.org/1419823010/diff/190001/src/bootstrapper.cc
File src/bootstrapper.cc (right):

https://codereview.chromium.org/1419823010/diff/190001/src/bootstrapper.cc#ne...
src/bootstrapper.cc:1228: Map::EnsureDescriptorSlack(initial_map, 5);
DBC: shouldn't it now reserve only 3 entries?

[Yang, 2015-11-06 20:49:44]

On 2015/11/06 19:34:34, Igor Sheludko wrote:
> https://codereview.chromium.org/1419823010/diff/190001/src/bootstrapper.cc
> File src/bootstrapper.cc (right):
> 
>
https://codereview.chromium.org/1419823010/diff/190001/src/bootstrapper.cc#ne...
> src/bootstrapper.cc:1228: Map::EnsureDescriptorSlack(initial_map, 5);
> DBC: shouldn't it now reserve only 3 entries?

Yes. I fixed this in a follow-up here:
https://codereview.chromium.org/1428203003/diff/80001/src/bootstrapper.cc
(I changed it to reserve only 1 entry because we don't use private symbols as
keys for internal slots anymore).