src/js/symbol.js - Issue 1419823010: Implement flag and source getters on RegExp.prototype. - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(372)

My Issues | Starred Open | Closed | All

Unified Diff: src/js/symbol.js

Issue 1419823010: Implement flag and source getters on RegExp.prototype. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@rproto

Patch Set: new webkit expectations Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« src/bootstrapper.cc ('K') | « src/js/string.js ('k') | src/messages.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: src/js/symbol.js

diff --git a/src/js/symbol.js b/src/js/symbol.js

index bb03ed211cac51ab82370b05e2c636b179dde0ad..62ef0dd2167bfc6185bde0adf0d92775a7b16464 100644

--- a/src/js/symbol.js

+++ b/src/js/symbol.js

@@ -16,7 +16,6 @@ var GlobalSymbol = global.Symbol;

var hasInstanceSymbol = utils.ImportNow("has_instance_symbol");

var isConcatSpreadableSymbol =

utils.ImportNow("is_concat_spreadable_symbol");

-var isRegExpSymbol = utils.ImportNow("is_regexp_symbol");

var iteratorSymbol = utils.ImportNow("iterator_symbol");

var MakeTypeError;

var ObjectGetOwnPropertyKeys;

@@ -94,7 +93,6 @@ utils.InstallConstants(GlobalSymbol, [

// TODO(rossberg): expose when implemented.

// "hasInstance", hasInstanceSymbol,

// "isConcatSpreadable", isConcatSpreadableSymbol,

- // "isRegExp", isRegExpSymbol,

"iterator", iteratorSymbol,

// TODO(yangguo): expose when implemented.

// "match", matchSymbol,

« src/bootstrapper.cc ('K') | « src/js/string.js ('k') | src/messages.h » ('j') | no next file with comments »

Powered by Google App Engine

This is Rietveld 408576698