Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: src/bootstrapper.cc

Issue 1419823010: Implement flag and source getters on RegExp.prototype. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@rproto
Patch Set: new webkit expectations Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/api.cc ('k') | src/heap/heap.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/bootstrapper.cc
diff --git a/src/bootstrapper.cc b/src/bootstrapper.cc
index 79e1a792413bc48def34ed1b412302908b7ac19a..0e0cd78b1891f9af197d37c385f3247be377eac1 100644
--- a/src/bootstrapper.cc
+++ b/src/bootstrapper.cc
@@ -1228,31 +1228,16 @@ void Genesis::InitializeGlobal(Handle<JSGlobalObject> global_object,
Map::EnsureDescriptorSlack(initial_map, 5);
Igor Sheludko 2015/11/06 19:34:34 DBC: shouldn't it now reserve only 3 entries?
{
- // ECMA-262, section 15.10.7.1.
- DataDescriptor field(factory->source_string(),
+ // ES6 21.2.3.2.1
+ DataDescriptor field(factory->regexp_source_symbol(),
JSRegExp::kSourceFieldIndex, final,
Representation::Tagged());
initial_map->AppendDescriptor(&field);
}
{
- // ECMA-262, section 15.10.7.2.
- DataDescriptor field(factory->global_string(),
- JSRegExp::kGlobalFieldIndex, final,
- Representation::Tagged());
- initial_map->AppendDescriptor(&field);
- }
- {
- // ECMA-262, section 15.10.7.3.
- DataDescriptor field(factory->ignore_case_string(),
- JSRegExp::kIgnoreCaseFieldIndex, final,
- Representation::Tagged());
- initial_map->AppendDescriptor(&field);
- }
- {
- // ECMA-262, section 15.10.7.4.
- DataDescriptor field(factory->multiline_string(),
- JSRegExp::kMultilineFieldIndex, final,
- Representation::Tagged());
+ DataDescriptor field(factory->regexp_flags_symbol(),
+ JSRegExp::kFlagsFieldIndex, final,
+ Representation::Smi());
initial_map->AppendDescriptor(&field);
}
{
@@ -2055,8 +2040,6 @@ void Bootstrapper::ExportExperimentalFromRuntime(Isolate* isolate,
isolate->factory()->ToBoolean(FLAG), NONE); \
}
- INITIALIZE_FLAG(FLAG_harmony_regexps)
- INITIALIZE_FLAG(FLAG_harmony_unicode_regexps)
INITIALIZE_FLAG(FLAG_harmony_tostring)
INITIALIZE_FLAG(FLAG_harmony_tolength)
« no previous file with comments | « src/api.cc ('k') | src/heap/heap.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698