Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Issue 1419823005: Invalidate background-attachment:fixed on scroll. (Closed)

Created:
5 years, 2 months ago by trchen
Modified:
5 years, 2 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2526
Target Ref:
refs/pending/branch-heads/2526
Project:
chromium
Visibility:
Public.

Description

Invalidate background-attachment:fixed on scroll. If there is any slow repaint objects (i.e. background-attachment:fixed), we fall back to the FrameView::scrollContentsSlowPath() that invalidates the whole main graphics layer. However this is not correct because the object is not necessarily backed by the main backing. We should invalidate them individually. Note: This approach is still not entirely correct. With composited overflow scrolling, we should inhibit threaded scrolling when a slow repaint descandant presents and do similar invalidation. This is non-trivial to implement. As the old compositing architecture is deprecated anyway, we will try to fix the issue with SPv2. BUG=540499 Review URL: https://codereview.chromium.org/1394193003 Cr-Commit-Position: refs/heads/master@{#354960} (cherry picked from commit 1d3aacc9cd5028db3a36036bfbace8933097be00) Committed: https://chromium.googlesource.com/chromium/src/+/1b2f6c936db5ae22b9cb20818b625321e353783b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -45 lines) Patch
A third_party/WebKit/LayoutTests/compositing/repaint/background-attachment-fixed-scrolled.html View 1 chunk +27 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/compositing/repaint/background-attachment-fixed-scrolled-expected.html View 1 chunk +23 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/full-viewport-repaint-for-background-attachment-fixed-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.h View 4 chunks +7 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 4 chunks +21 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 2 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp View 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
trchen
5 years, 2 months ago (2015-10-21 22:38:45 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1b2f6c936db5ae22b9cb20818b625321e353783b.

Powered by Google App Engine
This is Rietveld 408576698