Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp

Issue 1419823005: Invalidate background-attachment:fixed on scroll. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2526
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp
diff --git a/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp b/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp
index c3d76cbff054dcbb51fdf2c85fb24f7705210b7c..28cbd6e9aa9d95f088123204370801a96c812a62 100644
--- a/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp
+++ b/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp
@@ -905,7 +905,7 @@ void ScrollingCoordinator::computeTouchEventTargetRects(LayerHitTestRects& rects
accumulateDocumentTouchEventTargetRects(rects, document);
}
-void ScrollingCoordinator::frameViewHasSlowRepaintObjectsDidChange(FrameView* frameView)
+void ScrollingCoordinator::frameViewHasBackgroundAttachmentFixedObjectsDidChange(FrameView* frameView)
{
ASSERT(isMainThread());
ASSERT(m_page);
@@ -1031,8 +1031,8 @@ MainThreadScrollingReasons ScrollingCoordinator::mainThreadScrollingReasons() co
if (!frameView)
return reasons;
- if (frameView->hasSlowRepaintObjects())
- reasons |= HasSlowRepaintObjects;
+ if (frameView->hasBackgroundAttachmentFixedObjects())
+ reasons |= HasBackgroundAttachmentFixedObjects;
FrameView::ScrollingReasons scrollingReasons = frameView->scrollingReasons();
const bool mayBeScrolledByInput = (scrollingReasons == FrameView::Scrollable);
const bool mayBeScrolledByScript = mayBeScrolledByInput || (scrollingReasons ==
@@ -1053,8 +1053,8 @@ String ScrollingCoordinator::mainThreadScrollingReasonsAsText(MainThreadScrollin
{
StringBuilder stringBuilder;
- if (reasons & ScrollingCoordinator::HasSlowRepaintObjects)
- stringBuilder.appendLiteral("Has slow repaint objects, ");
+ if (reasons & ScrollingCoordinator::HasBackgroundAttachmentFixedObjects)
+ stringBuilder.appendLiteral("Has background-attachment:fixed, ");
if (reasons & ScrollingCoordinator::HasNonLayerViewportConstrainedObjects)
stringBuilder.appendLiteral("Has non-layer viewport-constrained objects, ");
if (reasons & ScrollingCoordinator::ThreadedScrollingDisabled)
« no previous file with comments | « third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698