Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 1419813010: [runtime] Remove the very dangerous %_CallFunction intrinsic. (Closed)

Created:
5 years, 1 month ago by Benedikt Meurer
Modified:
5 years, 1 month ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Remove the very dangerous %_CallFunction intrinsic. The %_CallFunction doesn't implement the call sequence properly, it doesn't do the receiver wrapping, nor does it check for classConstructor. Also the eager deoptimization for %_CallFunction was seriously b0rked (we must have been lucky with TurboFan so far). R=yangguo@chromium.org BUG=v8:4413 LOG=n Committed: https://crrev.com/a210c3757eed746beba7743385a990bf804bd6e9 Cr-Commit-Position: refs/heads/master@{#31821}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+176 lines, -571 lines) Patch
M src/compiler/js-intrinsic-lowering.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/js-intrinsic-lowering.cc View 2 chunks +5 lines, -12 lines 0 comments Download
M src/compiler/linkage.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/crankshaft/hydrogen.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/crankshaft/hydrogen.cc View 1 chunk +0 lines, -46 lines 0 comments Download
M src/debug/debug.js View 1 chunk +1 line, -1 line 0 comments Download
M src/debug/mirrors.js View 29 chunks +30 lines, -30 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 chunk +0 lines, -33 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 2 chunks +1 line, -34 lines 0 comments Download
M src/full-codegen/full-codegen.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 chunk +0 lines, -33 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 chunk +0 lines, -33 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 chunk +0 lines, -33 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +0 lines, -33 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 chunk +0 lines, -33 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +0 lines, -33 lines 0 comments Download
M src/js/array.js View 1 chunk +1 line, -1 line 0 comments Download
M src/js/code-stubs.js View 1 chunk +1 line, -1 line 0 comments Download
M src/js/date.js View 3 chunks +3 lines, -3 lines 0 comments Download
M src/js/generator.js View 1 chunk +1 line, -1 line 0 comments Download
M src/js/i18n.js View 17 chunks +51 lines, -54 lines 0 comments Download
M src/js/macros.py View 1 chunk +1 line, -1 line 0 comments Download
M src/js/messages.js View 11 chunks +28 lines, -32 lines 0 comments Download
M src/js/promise.js View 7 chunks +9 lines, -9 lines 0 comments Download
M src/js/proxy.js View 3 chunks +3 lines, -3 lines 0 comments Download
M src/js/string.js View 2 chunks +3 lines, -4 lines 0 comments Download
M src/js/templates.js View 2 chunks +3 lines, -3 lines 0 comments Download
M src/js/v8natives.js View 6 chunks +8 lines, -8 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime-function.cc View 1 chunk +0 lines, -33 lines 0 comments Download
M test/cctest/compiler/test-run-intrinsics.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M test/mjsunit/call-runtime-tail.js View 5 chunks +5 lines, -5 lines 0 comments Download
M test/mjsunit/compiler/regress-lazy-deopt.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/harmony/proxies-function.js View 7 chunks +12 lines, -12 lines 0 comments Download
M test/mjsunit/regress/call-function-in-effect-context-deopt.js View 1 chunk +1 line, -1 line 0 comments Download
D test/mjsunit/regress/regress-2285.js View 1 chunk +0 lines, -31 lines 0 comments Download
M test/mjsunit/regress/regress-3183.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-crbug-405922.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/strong/function-arity.js View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 1 month ago (2015-11-05 11:23:32 UTC) #1
Benedikt Meurer
Hey Yang, This removes the very horrible %_CallFunction intrinsic and uses the sane %_Call one ...
5 years, 1 month ago (2015-11-05 11:26:18 UTC) #2
Yang
lgtm. good riddance!
5 years, 1 month ago (2015-11-05 11:29:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1419813010/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1419813010/1
5 years, 1 month ago (2015-11-05 11:41:55 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-05 11:48:12 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-05 11:48:28 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a210c3757eed746beba7743385a990bf804bd6e9
Cr-Commit-Position: refs/heads/master@{#31821}

Powered by Google App Engine
This is Rietveld 408576698