src/js/code-stubs.js - Issue 1419813010: [runtime] Remove the very dangerous %_CallFunction intrinsic.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/js/code-stubs.js

Issue 1419813010: [runtime] Remove the very dangerous %_CallFunction intrinsic. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/js/code-stubs.js

diff --git a/src/js/code-stubs.js b/src/js/code-stubs.js

index ab06f6c63b1fb640755f2970121fc13c15262379..7cb10d726a759b34827b65938e1c982d96a20d13 100644

--- a/src/js/code-stubs.js

+++ b/src/js/code-stubs.js

@@ -35,7 +35,7 @@ code_stubs.MathFloorStub = function MathFloorStub(call_conv, minor_key) {

// |tv| is the calling function's type vector

// |v| is the value to floor

if (f !== %_FixedArrayGet(tv, i|0)) {

- return %_CallFunction(receiver, v, f);

+ return %_Call(f, receiver, v);

}

var r = %_MathFloor(+v);

if (%_IsMinusZero(r)) {

« no previous file with comments | « src/js/array.js ('k') | src/js/date.js » ('j') | no next file with comments »