Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Unified Diff: src/js/date.js

Issue 1419813010: [runtime] Remove the very dangerous %_CallFunction intrinsic. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/js/code-stubs.js ('k') | src/js/generator.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/js/date.js
diff --git a/src/js/date.js b/src/js/date.js
index 1e8ef166790a3e3b628b308cde45e80c653fd3ff..a99d8e4d51fec8cf3f68f36539ae16ce1133c226 100644
--- a/src/js/date.js
+++ b/src/js/date.js
@@ -134,7 +134,7 @@ var Date_cache = {
function DateConstructor(year, month, date, hours, minutes, seconds, ms) {
if (!%_IsConstructCall()) {
// ECMA 262 - 15.9.2
- return %_CallFunction(new GlobalDate(), DateToString);
+ return %_Call(DateToString, new GlobalDate());
}
// ECMA 262 - 15.9.3
@@ -337,7 +337,7 @@ function DateToTimeString() {
// ECMA 262 - 15.9.5.5
function DateToLocaleString() {
CHECK_DATE(this);
- return %_CallFunction(this, DateToString);
+ return %_Call(DateToString, this);
}
@@ -735,7 +735,7 @@ function DateSetYear(year) {
// do that either. Instead, we create a new function whose name
// property will return toGMTString.
function DateToGMTString() {
- return %_CallFunction(this, DateToUTCString);
+ return %_Call(DateToUTCString, this);
}
« no previous file with comments | « src/js/code-stubs.js ('k') | src/js/generator.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698