Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1410343009: [WIP] Web Animations: Migrate SVG number list interpolation to interpolation types (Closed)

Created:
5 years, 1 month ago by Timothy Loh
Modified:
5 years, 1 month ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Web Animations: Migrate SVG number list interpolation to interpolation types BUG=530436

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Messages

Total messages: 6 (2 generated)
Timothy Loh
5 years, 1 month ago (2015-11-03 03:14:46 UTC) #2
alancutter (OOO until 2018)
https://codereview.chromium.org/1410343009/diff/1/third_party/WebKit/Source/core/animation/SVGNumberListInterpolationType.cpp File third_party/WebKit/Source/core/animation/SVGNumberListInterpolationType.cpp (right): https://codereview.chromium.org/1410343009/diff/1/third_party/WebKit/Source/core/animation/SVGNumberListInterpolationType.cpp#newcode23 third_party/WebKit/Source/core/animation/SVGNumberListInterpolationType.cpp:23: const SVGNumberList& svgList = static_cast<const SVGNumberList&>(svgValue); Add DEFINE_SVG_PROPERTY_TYPE_CASTS() to ...
5 years, 1 month ago (2015-11-03 03:23:58 UTC) #3
alancutter (OOO until 2018)
https://codereview.chromium.org/1410343009/diff/1/third_party/WebKit/LayoutTests/animations/svg-attribute-composition/svg-tableValues-composition.html File third_party/WebKit/LayoutTests/animations/svg-attribute-composition/svg-tableValues-composition.html (right): https://codereview.chromium.org/1410343009/diff/1/third_party/WebKit/LayoutTests/animations/svg-attribute-composition/svg-tableValues-composition.html#newcode28 third_party/WebKit/LayoutTests/animations/svg-attribute-composition/svg-tableValues-composition.html:28: ]); Add an add -> add test with an ...
5 years, 1 month ago (2015-11-03 03:28:25 UTC) #4
Timothy Loh
5 years, 1 month ago (2015-11-03 05:26:15 UTC) #5 
added more tests. composite needs to be updated to pad with zeros I think?

Powered by Google App Engine
This is Rietveld 408576698