Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issue 141953013: Revert 245663 "Revert 245645 "Define WebScrollOffsetAnimationCur..." (Closed)

Created:
6 years, 11 months ago by Dan Beam
Modified:
6 years, 11 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 245663 "Revert 245645 "Define WebScrollOffsetAnimationCur..." > Revert 245645 "Define WebScrollOffsetAnimationCurveImpl" > > Broke compositor_unittests on Linux Aura Tests with error: I'm a dirty liar. > > LayerWithRealCompositorTest.DrawPixels (run #1): > [ RUN ] LayerWithRealCompositorTest.DrawPixels > ../../ui/compositor/layer_unittest.cc:832: Failure > Value of: ReadPixels(&bitmap, gfx::Rect(viewport_size)) > Actual: false > Expected: true > [ FAILED ] LayerWithRealCompositorTest.DrawPixels (246 ms) > > LayerWithRealCompositorTest.DrawPixels (run #2): > [ RUN ] LayerWithRealCompositorTest.DrawPixels > ../../ui/compositor/layer_unittest.cc:832: Failure > Value of: ReadPixels(&bitmap, gfx::Rect(viewport_size)) > Actual: false > Expected: true > [ FAILED ] LayerWithRealCompositorTest.DrawPixels (272 ms) > > LayerWithRealCompositorTest.DrawPixels (run #3): > [ RUN ] LayerWithRealCompositorTest.DrawPixels > ../../ui/compositor/layer_unittest.cc:832: Failure > Value of: ReadPixels(&bitmap, gfx::Rect(viewport_size)) > Actual: false > Expected: true > [ FAILED ] LayerWithRealCompositorTest.DrawPixels (259 ms) > > LayerWithRealCompositorTest.DrawPixels (run #4): > [ RUN ] LayerWithRealCompositorTest.DrawPixels > ../../ui/compositor/layer_unittest.cc:832: Failure > Value of: ReadPixels(&bitmap, gfx::Rect(viewport_size)) > Actual: false > Expected: true > [ FAILED ] LayerWithRealCompositorTest.DrawPixels (229 ms) > > > Define WebScrollOffsetAnimationCurveImpl > > > > This defines WebScrollOffsetAnimationCurveImpl, which wraps a > > cc::ScrollOffsetAnimationCurve. This is needed for > > implementing the CSSOM Smooth Scroll API. > > > > BUG=243871 > > > > Review URL: https://codereview.chromium.org/112933005 > > TBR=ajuma@chromium.org > > Review URL: https://codereview.chromium.org/141753007 TBR=dbeam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245674

Patch Set 1 #

Messages

Total messages: 2 (0 generated)
Dan Beam
6 years, 11 months ago (2014-01-18 00:25:23 UTC) #1
Dan Beam
6 years, 11 months ago (2014-01-18 00:28:24 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r245674 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698