Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 112933005: Define WebScrollOffsetAnimationCurveImpl (Closed)

Created:
7 years ago by ajuma
Modified:
6 years, 11 months ago
Reviewers:
Ian Vollick, jamesr
CC:
chromium-reviews, cc-bugs_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Define WebScrollOffsetAnimationCurveImpl This defines WebScrollOffsetAnimationCurveImpl, which wraps a cc::ScrollOffsetAnimationCurve. This is needed for implementing the CSSOM Smooth Scroll API. BUG=243871 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245645

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -3 lines) Patch
M cc/animation/animation.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/animation/animation.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/renderer/compositor_bindings/compositor_bindings.gyp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M webkit/renderer/compositor_bindings/web_animation_impl.cc View 3 chunks +13 lines, -0 lines 0 comments Download
M webkit/renderer/compositor_bindings/web_compositor_support_impl.h View 2 chunks +7 lines, -0 lines 0 comments Download
M webkit/renderer/compositor_bindings/web_compositor_support_impl.cc View 3 chunks +13 lines, -0 lines 0 comments Download
A webkit/renderer/compositor_bindings/web_scroll_offset_animation_curve_impl.h View 1 1 chunk +51 lines, -0 lines 0 comments Download
A webkit/renderer/compositor_bindings/web_scroll_offset_animation_curve_impl.cc View 1 1 chunk +52 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
ajuma
The Blink side of this change is part of http://crrev.com/134443003.
6 years, 11 months ago (2014-01-14 17:54:05 UTC) #1
Ian Vollick
On 2014/01/14 17:54:05, ajuma wrote: > The Blink side of this change is part of ...
6 years, 11 months ago (2014-01-17 13:53:44 UTC) #2
ajuma
+jamesr for webkit/
6 years, 11 months ago (2014-01-17 14:04:16 UTC) #3
jamesr
Why does a scroll offset animation need a new curve type? Wouldn't it just be ...
6 years, 11 months ago (2014-01-17 20:42:24 UTC) #4
ajuma
On 2014/01/17 20:42:24, jamesr wrote: > Why does a scroll offset animation need a new ...
6 years, 11 months ago (2014-01-17 20:53:30 UTC) #5
jamesr
seems unfortunate that we can't build this out of existing primitives :( lgtm
6 years, 11 months ago (2014-01-17 21:02:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ajuma@chromium.org/112933005/70001
6 years, 11 months ago (2014-01-17 21:05:42 UTC) #7
commit-bot: I haz the power
6 years, 11 months ago (2014-01-17 22:37:29 UTC) #8
Message was sent while issue was closed.
Change committed as 245645

Powered by Google App Engine
This is Rietveld 408576698