Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 141753007: Revert 245645 "Define WebScrollOffsetAnimationCurveImpl" (Closed)

Created:
6 years, 11 months ago by Dan Beam
Modified:
6 years, 11 months ago
Reviewers:
ajuma
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 245645 "Define WebScrollOffsetAnimationCurveImpl" Broke compositor_unittests on Linux Aura Tests with error: LayerWithRealCompositorTest.DrawPixels (run #1): [ RUN ] LayerWithRealCompositorTest.DrawPixels ../../ui/compositor/layer_unittest.cc:832: Failure Value of: ReadPixels(&bitmap, gfx::Rect(viewport_size)) Actual: false Expected: true [ FAILED ] LayerWithRealCompositorTest.DrawPixels (246 ms) LayerWithRealCompositorTest.DrawPixels (run #2): [ RUN ] LayerWithRealCompositorTest.DrawPixels ../../ui/compositor/layer_unittest.cc:832: Failure Value of: ReadPixels(&bitmap, gfx::Rect(viewport_size)) Actual: false Expected: true [ FAILED ] LayerWithRealCompositorTest.DrawPixels (272 ms) LayerWithRealCompositorTest.DrawPixels (run #3): [ RUN ] LayerWithRealCompositorTest.DrawPixels ../../ui/compositor/layer_unittest.cc:832: Failure Value of: ReadPixels(&bitmap, gfx::Rect(viewport_size)) Actual: false Expected: true [ FAILED ] LayerWithRealCompositorTest.DrawPixels (259 ms) LayerWithRealCompositorTest.DrawPixels (run #4): [ RUN ] LayerWithRealCompositorTest.DrawPixels ../../ui/compositor/layer_unittest.cc:832: Failure Value of: ReadPixels(&bitmap, gfx::Rect(viewport_size)) Actual: false Expected: true [ FAILED ] LayerWithRealCompositorTest.DrawPixels (229 ms) > Define WebScrollOffsetAnimationCurveImpl > > This defines WebScrollOffsetAnimationCurveImpl, which wraps a > cc::ScrollOffsetAnimationCurve. This is needed for > implementing the CSSOM Smooth Scroll API. > > BUG=243871 > > Review URL: https://codereview.chromium.org/112933005 TBR=ajuma@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245663

Patch Set 1 #

Messages

Total messages: 2 (0 generated)
Dan Beam
6 years, 11 months ago (2014-01-17 23:58:23 UTC) #1
Dan Beam
6 years, 11 months ago (2014-01-17 23:58:56 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r245663 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698