Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1419503006: fix breaking third parties using grit (Closed)

Created:
5 years, 1 month ago by fqj
Modified:
5 years, 1 month ago
CC:
chromium-reviews, kjellander_chromium
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

fix breaking third parties using grit BUG= Committed: https://crrev.com/8ef898c7c836d61f186ea475ca100201de8adc92 Cr-Commit-Position: refs/heads/master@{#358025}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M build/chrome_settings.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M build/grit_action.gypi View 2 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
fqj
scottmg: please review kjellander: is this CL okay for third-party builds using grit?
5 years, 1 month ago (2015-11-04 09:33:46 UTC) #2
kjellander_chromium
Yes, I've confirmed this solves our problem. Thanks!
5 years, 1 month ago (2015-11-04 09:51:47 UTC) #4
scottmg
If kjellander's happy and chgromium is happy lgtm :)
5 years, 1 month ago (2015-11-04 17:56:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1419503006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1419503006/1
5 years, 1 month ago (2015-11-05 09:53:57 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-05 11:03:36 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-11-05 11:04:21 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/8ef898c7c836d61f186ea475ca100201de8adc92
Cr-Commit-Position: refs/heads/master@{#358025}

Powered by Google App Engine
This is Rietveld 408576698