build/chrome_settings.gypi - Issue 1419503006: fix breaking third parties using grit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/chrome_settings.gypi

Issue 1419503006: fix breaking third parties using grit (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/chrome_settings.gypi

diff --git a/build/chrome_settings.gypi b/build/chrome_settings.gypi

index e9c753554de3b593998c445d6a337b6ed5ab0bfd..646b2098b63440c743b17fbccfe2abe2f3065d64 100644

--- a/build/chrome_settings.gypi

+++ b/build/chrome_settings.gypi

@@ -8,6 +8,8 @@

'variables': {

# TODO: remove this helper when we have loops in GYP

'apply_locales_cmd': ['python', '<(DEPTH)/build/apply_locales.py'],

+ 'grit_defines': ['-D', 'version=<(version_full)'],

+ 'includes': ['util/version.gypi'],

'conditions': [

['OS=="mac"', {

« no previous file with comments | « no previous file | build/grit_action.gypi » ('j') | no next file with comments »