Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1798)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/grit_action.gypi

Issue 1419503006: fix breaking third parties using grit (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/chrome_settings.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/grit_action.gypi
diff --git a/build/grit_action.gypi b/build/grit_action.gypi
index f294ff0a16b9caaa01b1dcf4c535efa9cdaaf3e5..b24f0f8d715cd0333db9b9cb9e16a7635657878a 100644
--- a/build/grit_action.gypi
+++ b/build/grit_action.gypi
@@ -19,7 +19,7 @@
'grit_resource_ids%': '<(DEPTH)/tools/gritsettings/resource_ids',
# This makes it possible to add more defines in specific targets,
# instead of build/common.gypi .
- 'grit_additional_defines%': ['-D', 'version=<(version_full)'],
+ 'grit_additional_defines%': [],
'grit_rc_header_format%': [],
'grit_whitelist%': '',
@@ -37,9 +37,6 @@
}],
],
},
- 'includes': [
- '../build/util/version.gypi'
- ],
'conditions': [
['"<(grit_whitelist)"==""', {
'variables': {
« no previous file with comments | « build/chrome_settings.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698