Issue 14195025: Keep vsync enabled while there is a pending requestAnimationFrame

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14195025: Keep vsync enabled while there is a pending requestAnimationFrame (Closed)

Created:
7 years, 8 months ago by Sami

Modified:
7 years, 8 months ago

Reviewers:
brianderson

CC:
chromium-reviews, cc-bugs_chromium.org, Tom Hudson, brianderson

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Keep vsync enabled while there is a pending requestAnimationFrame When the vsync signal is enabled from an idle state, it will only fire at the start of the next vsync interval, which may be a full frame away. If a requestAnimationFrame is pending, we are likely to need the vsync signal soon, so turn it on pre-emptively. BUG=161828

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+29 lines, -0 lines)			Patch
M	cc/scheduler/scheduler.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cc/scheduler/scheduler.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	cc/scheduler/scheduler_state_machine.h	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	cc/scheduler/scheduler_state_machine.cc	View	4 chunks	+9 lines, -0 lines	0 comments	Download
M	cc/trees/thread_proxy.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	cc/trees/thread_proxy.cc	View	2 chunks	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

brianderson

Is this patch primarily helpful because there's some delay before the Browser will sent back ...

7 years, 8 months ago (2013-04-19 00:45:26 UTC) #2

nduca

7 years, 8 months ago (2013-04-22 23:16:06 UTC) #3

Why special case raf? Why not just keep vsync on longer and delay turn it off
after a few frames of quiescence?

Expand Messages | Collapse Messages