Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 1419143008: Revert of Parse outline shorthand in CSSPropertyParser with CSSParserTokens (Closed)

Created:
5 years, 1 month ago by michaeln
Modified:
5 years, 1 month ago
Reviewers:
Timothy Loh, rwlbuis
CC:
chromium-reviews, blink-reviews-style_chromium.org, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Parse outline shorthand in CSSPropertyParser with CSSParserTokens (patchset #5 id:80001 of https://codereview.chromium.org/1406343008/ ) Reason for revert: Reverting in order to revert a suspected top crasher. See the bug for details. BUG=551638 Original issue's description: > Parse outline shorthand in CSSPropertyParser with CSSParserTokens > > Move outline shorthand property handling from > LegacyCSSPropertyParser into CSSPropertyParser. Also > move its related longhands. > > BUG=499780 > > Committed: https://crrev.com/3447a99f8dce411d4e07c55e6b81dd2068a50390 > Cr-Commit-Position: refs/heads/master@{#358065} TBR=timloh@chromium.org,rob.buis@samsung.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=499780 Committed: https://crrev.com/4bae7285907b6ca814aa7dac4e20e29972c5e755 Cr-Commit-Position: refs/heads/master@{#358127}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -29 lines) Patch
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 3 chunks +0 lines, -25 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp View 5 chunks +15 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
michaeln
Created Revert of Parse outline shorthand in CSSPropertyParser with CSSParserTokens
5 years, 1 month ago (2015-11-05 20:34:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1419143008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1419143008/1
5 years, 1 month ago (2015-11-05 20:53:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1419143008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1419143008/1
5 years, 1 month ago (2015-11-05 21:05:41 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-05 21:07:28 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-11-05 21:08:27 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4bae7285907b6ca814aa7dac4e20e29972c5e755
Cr-Commit-Position: refs/heads/master@{#358127}

Powered by Google App Engine
This is Rietveld 408576698