Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp

Issue 1419143008: Revert of Parse outline shorthand in CSSPropertyParser with CSSParserTokens (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp
diff --git a/third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp b/third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp
index 7e524b692ee5e7c286ac6fdfd15fdbb183b6ec8a..996a5a79918f8e16419ddf4edc28c8adeeb3a907 100644
--- a/third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp
+++ b/third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp
@@ -420,6 +420,14 @@
}
break;
+ case CSSPropertyOutlineColor: // <color> | invert | inherit
+ // Outline color has "invert" as additional keyword.
+ // Also, we want to allow the special focus color even in HTML Standard parsing mode.
+ if (id == CSSValueInvert || id == CSSValueWebkitFocusRingColor) {
+ validPrimitive = true;
+ break;
+ }
+ /* nobreak */
case CSSPropertyBackgroundColor: // <color> | inherit
case CSSPropertyBorderTopColor: // <color> | inherit
case CSSPropertyBorderRightColor:
@@ -601,6 +609,7 @@
unitless = FUnitlessQuirk;
// fall through
case CSSPropertyWebkitTextStrokeWidth:
+ case CSSPropertyOutlineWidth: // <border-width> | inherit
case CSSPropertyWebkitBorderStartWidth:
case CSSPropertyWebkitBorderEndWidth:
case CSSPropertyWebkitBorderBeforeWidth:
@@ -741,6 +750,9 @@
case CSSPropertyBorderRadius:
case CSSPropertyAliasWebkitBorderRadius:
return parseBorderRadius(unresolvedProperty, important);
+ case CSSPropertyOutlineOffset:
+ validPrimitive = validUnit(value, FLength);
+ break;
case CSSPropertyWebkitBoxReflect:
if (id == CSSValueNone)
validPrimitive = true;
@@ -1031,6 +1043,9 @@
return parseShorthand(propId, webkitBorderBeforeShorthand(), important);
case CSSPropertyWebkitBorderAfter:
return parseShorthand(propId, webkitBorderAfterShorthand(), important);
+ case CSSPropertyOutline:
+ // [ 'outline-color' || 'outline-style' || 'outline-width' ] | inherit
+ return parseShorthand(propId, outlineShorthand(), important);
case CSSPropertyBorderColor:
// <color>{1,4} | inherit
return parse4Values(propId, borderColorShorthand().properties(), important);
@@ -1195,10 +1210,6 @@
case CSSPropertyWebkitTextDecorationsInEffect:
case CSSPropertyTextDecorationLine:
case CSSPropertyTextDecoration:
- case CSSPropertyOutline:
- case CSSPropertyOutlineColor:
- case CSSPropertyOutlineWidth:
- case CSSPropertyOutlineOffset:
validPrimitive = false;
break;
« no previous file with comments | « third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698