Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 1418933002: Revert of Cleanup chrome/version.h handling (Closed)

Created:
5 years, 2 months ago by Mathieu
Modified:
5 years, 2 months ago
Reviewers:
brettw, mdempsky
CC:
chromium-reviews, grt+watch_chromium.org, wfh+watch_chromium.org, caitkp+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Cleanup chrome/version.h handling (patchset #9 id:160001 of https://codereview.chromium.org/1405633002/ ) Reason for revert: Causing failures on the GN build (not gyp) for Mac: http://build.chromium.org/p/chromium.mac/builders/Mac%20GN%20%28dbg%29/builds/23191 Original issue's description: > Cleanup chrome/common/chrome_version.h handling > > Rename "version.h" to "chrome/common/chrome_version.h" > Update #include and GYP/GN references > Generate on all platforms > Remove redundant generated chrome/common/chrome_version.cc.version > Fix DEPS include_rules > > BUG=542807 > > Committed: https://crrev.com/59647ecac9524d954010d3d10b539ee4a340bf94 > Cr-Commit-Position: refs/heads/master@{#355196} > > Committed: https://crrev.com/31f086c2013853749cac45522eb950b9d0ab0302 > Cr-Commit-Position: refs/heads/master@{#355377} TBR=brettw@chromium.org,mdempsky@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=542807 Committed: https://crrev.com/43a8e38f6318192b107626d74e75c90d8d99f885 Cr-Commit-Position: refs/heads/master@{#355393}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -113 lines) Patch
M chrome/BUILD.gn View 1 chunk +16 lines, -0 lines 0 comments Download
M chrome/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_elf_init_unittest_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_elf_init_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/google/google_update_win_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer_win_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome.gyp View 1 chunk +35 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_installer.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/BUILD.gn View 3 chunks +8 lines, -16 lines 0 comments Download
M chrome/common/chrome_constants.cc View 2 chunks +0 lines, -3 lines 0 comments Download
A chrome/common/chrome_version.cc.version View 1 chunk +11 lines, -0 lines 0 comments Download
D chrome/common/chrome_version.h.in View 1 chunk +0 lines, -24 lines 0 comments Download
M chrome/common_constants.gyp View 3 chunks +35 lines, -49 lines 0 comments Download
M chrome/installer/setup/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/setup/setup_main.cc View 2 chunks +1 line, -1 line 0 comments Download
A chrome/version.h.in View 1 chunk +24 lines, -0 lines 0 comments Download
M chrome_elf/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chrome_elf/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome_elf/blacklist/test/blacklist_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome_elf/breakpad.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome_elf/chrome_elf.gyp View 2 chunks +2 lines, -1 line 0 comments Download
M cloud_print/cloud_print_resources.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M cloud_print/service/service.gyp View 1 chunk +1 line, -1 line 0 comments Download
M cloud_print/virtual_driver/win/port_monitor/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M cloud_print/virtual_driver/win/virtual_driver.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Mathieu
Created Revert of Cleanup chrome/version.h handling
5 years, 2 months ago (2015-10-21 20:51:39 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1418933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1418933002/1
5 years, 2 months ago (2015-10-21 20:52:13 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-21 20:54:08 UTC) #3
commit-bot: I haz the power
5 years, 2 months ago (2015-10-21 20:55:08 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/43a8e38f6318192b107626d74e75c90d8d99f885
Cr-Commit-Position: refs/heads/master@{#355393}

Powered by Google App Engine
This is Rietveld 408576698