Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4110)

Unified Diff: chrome/common/BUILD.gn

Issue 1418933002: Revert of Cleanup chrome/version.h handling (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/chrome_tests.gypi ('k') | chrome/common/chrome_constants.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/BUILD.gn
diff --git a/chrome/common/BUILD.gn b/chrome/common/BUILD.gn
index 97019946ded0b3feb11af9fb07f07db8d00bccde..e1f8f3a3939bc1fe698ae43e6f124680a418d565 100644
--- a/chrome/common/BUILD.gn
+++ b/chrome/common/BUILD.gn
@@ -36,7 +36,7 @@
}
}
-# GYP version: chrome/chrome_common.gypi:common
+# GYP version: chrome/chrome_common.gyp:common
static_library("common") {
sources = rebase_path(gypi_values.chrome_common_sources, ".", "//chrome")
defines = []
@@ -269,20 +269,12 @@
}
}
-# GYP version: chrome/common_constants.gyp:version_header
-process_version("version_header") {
- # TODO(brettw) this should have more reduced visibility, but chrome/browser
- # currently depends on this.
- #visibility = [ ":*" ]
-
- # This one just uses the custom template and no separate sources.
- sources = []
- template_file = "chrome_version.h.in"
-
- output = "$target_gen_dir/chrome_version.h"
-}
-
-# GYP version: chrome/common_constants.gyp:common_constants
+process_version("make_chrome_version") {
+ template_file = "chrome_version.cc.version"
+ output = "$target_gen_dir/chrome_version.cc"
+}
+
+# GN version: chrome/common_constants.gyp:common_constants
static_library("constants") {
sources = [
"chrome_constants.cc",
@@ -311,7 +303,7 @@
"//content/public/common:result_codes",
]
deps = [
- ":version_header",
+ ":make_chrome_version",
"//base",
"//base/third_party/dynamic_annotations",
"//components/bookmarks/common",
« no previous file with comments | « chrome/chrome_tests.gypi ('k') | chrome/common/chrome_constants.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698