Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Side by Side Diff: chrome/common/chrome_constants.cc

Issue 1418933002: Revert of Cleanup chrome/version.h handling (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/common/BUILD.gn ('k') | chrome/common/chrome_version.cc.version » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/chrome_constants.h" 5 #include "chrome/common/chrome_constants.h"
6 #include "chrome/common/chrome_version.h"
7 6
8 #define FPL FILE_PATH_LITERAL 7 #define FPL FILE_PATH_LITERAL
9 8
10 #if defined(OS_MACOSX) 9 #if defined(OS_MACOSX)
11 #define CHROMIUM_PRODUCT_STRING "Chromium" 10 #define CHROMIUM_PRODUCT_STRING "Chromium"
12 #if defined(GOOGLE_CHROME_BUILD) 11 #if defined(GOOGLE_CHROME_BUILD)
13 #define PRODUCT_STRING "Google Chrome" 12 #define PRODUCT_STRING "Google Chrome"
14 #elif defined(CHROMIUM_BUILD) 13 #elif defined(CHROMIUM_BUILD)
15 #define PRODUCT_STRING "Chromium" 14 #define PRODUCT_STRING "Chromium"
16 #else 15 #else
17 #error Unknown branding 16 #error Unknown branding
18 #endif 17 #endif
19 #endif // defined(OS_MACOSX) 18 #endif // defined(OS_MACOSX)
20 19
21 namespace chrome { 20 namespace chrome {
22 21
23 const char kChromeVersion[] = CHROME_VERSION_STRING;
24
25 #if defined(OS_WIN) 22 #if defined(OS_WIN)
26 const char kChromeVersionEnvVar[] = "CHROME_VERSION"; 23 const char kChromeVersionEnvVar[] = "CHROME_VERSION";
27 #endif 24 #endif
28 25
29 // The following should not be used for UI strings; they are meant 26 // The following should not be used for UI strings; they are meant
30 // for system strings only. UI changes should be made in the GRD. 27 // for system strings only. UI changes should be made in the GRD.
31 // 28 //
32 // There are four constants used to locate the executable name and path: 29 // There are four constants used to locate the executable name and path:
33 // 30 //
34 // kBrowserProcessExecutableName 31 // kBrowserProcessExecutableName
(...skipping 195 matching lines...) Expand 10 before | Expand all | Expand 10 after
230 // user can select for different file types. 227 // user can select for different file types.
231 // {2676A9A2-D919-4FEE-9187-152100393AB2} 228 // {2676A9A2-D919-4FEE-9187-152100393AB2}
232 const char kApplicationClientIDStringForAVScanning[] = 229 const char kApplicationClientIDStringForAVScanning[] =
233 "2676A9A2-D919-4FEE-9187-152100393AB2"; 230 "2676A9A2-D919-4FEE-9187-152100393AB2";
234 231
235 const size_t kMaxMetaTagAttributeLength = 2000; 232 const size_t kMaxMetaTagAttributeLength = 2000;
236 233
237 } // namespace chrome 234 } // namespace chrome
238 235
239 #undef FPL 236 #undef FPL
OLDNEW
« no previous file with comments | « chrome/common/BUILD.gn ('k') | chrome/common/chrome_version.cc.version » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698