Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 141893004: Support default values for arrays of POD data types in mojom. (Closed)

Created:
6 years, 11 months ago by Matt Perry
Modified:
6 years, 11 months ago
CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium
Visibility:
Public.

Description

Support default values for arrays of POD data types in mojom. TODO: defaults values for structs BUG=320082 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246994

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -2 lines) Patch
M mojo/public/bindings/generators/cpp_templates/struct_builder_definition.tmpl View 1 chunk +8 lines, -0 lines 0 comments Download
M mojo/public/bindings/generators/mojom_cpp_generator.py View 1 1 chunk +1 line, -0 lines 0 comments Download
M mojo/public/bindings/generators/mojom_js_generator.py View 1 1 chunk +6 lines, -1 line 0 comments Download
M mojo/public/bindings/pylib/parse/mojo_parser.py View 1 2 2 chunks +18 lines, -0 lines 0 comments Download
M mojo/public/bindings/sample/sample_service_unittests.js View 1 chunk +5 lines, -0 lines 0 comments Download
M mojo/public/tests/bindings/sample_service.mojom View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/tests/bindings/sample_service_unittest.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Matt Perry
This builds upon https://codereview.chromium.org/138143003/
6 years, 11 months ago (2014-01-21 23:01:50 UTC) #1
darin (slow to review)
LGTM
6 years, 11 months ago (2014-01-23 22:56:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpcomplete@chromium.org/141893004/40001
6 years, 11 months ago (2014-01-23 23:13:45 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=250912
6 years, 11 months ago (2014-01-24 01:54:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpcomplete@chromium.org/141893004/40001
6 years, 11 months ago (2014-01-24 19:24:49 UTC) #5
commit-bot: I haz the power
Failed to apply patch for mojo/public/bindings/parse/mojo_parser.py: While running patch -p1 --forward --force --no-backup-if-mismatch; A mojo/public/bindings/parse ...
6 years, 11 months ago (2014-01-24 19:25:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpcomplete@chromium.org/141893004/410001
6 years, 11 months ago (2014-01-24 19:34:10 UTC) #7
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) telemetry_perf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=251483
6 years, 11 months ago (2014-01-24 20:25:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpcomplete@chromium.org/141893004/410001
6 years, 11 months ago (2014-01-24 21:07:25 UTC) #9
commit-bot: I haz the power
6 years, 11 months ago (2014-01-24 22:56:20 UTC) #10
Message was sent while issue was closed.
Change committed as 246994

Powered by Google App Engine
This is Rietveld 408576698