Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Unified Diff: mojo/public/bindings/generators/mojom_js_generator.py

Issue 141893004: Support default values for arrays of POD data types in mojom. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/public/bindings/generators/mojom_js_generator.py
diff --git a/mojo/public/bindings/generators/mojom_js_generator.py b/mojo/public/bindings/generators/mojom_js_generator.py
index 0596e888b3a2d3773e7e114a92caa3d142555e62..427ae991fb8984478a2a29637ac3ef682f252595 100644
--- a/mojo/public/bindings/generators/mojom_js_generator.py
+++ b/mojo/public/bindings/generators/mojom_js_generator.py
@@ -33,7 +33,12 @@ _kind_to_javascript_default_value = {
def JavaScriptDefaultValue(field):
if field.default:
- return field.default
+ if isinstance(field.default, list):
+ # TODO(mpcomplete): This will need to be more sophisticated to support
+ # arrays of objects/arrays.
+ return "[" + ", ".join(field.default) + "]"
+ else:
+ return field.default
if field.kind in mojom.PRIMITIVES:
return _kind_to_javascript_default_value[field.kind]
if isinstance(field.kind, mojom.Struct):
« no previous file with comments | « mojo/public/bindings/generators/mojom_cpp_generator.py ('k') | mojo/public/bindings/pylib/parse/mojo_parser.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698