Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Side by Side Diff: mojo/public/bindings/generators/mojom_js_generator.py

Issue 141893004: Support default values for arrays of POD data types in mojom. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 # Copyright 2013 The Chromium Authors. All rights reserved. 1 # Copyright 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Generates JavaScript source files from a mojom.Module.""" 5 """Generates JavaScript source files from a mojom.Module."""
6 6
7 import mojom 7 import mojom
8 import mojom_pack 8 import mojom_pack
9 import mojom_generator 9 import mojom_generator
10 10
(...skipping 15 matching lines...) Expand all
26 mojom.MSGPIPE: "core.kInvalidHandle", 26 mojom.MSGPIPE: "core.kInvalidHandle",
27 mojom.INT64: "0", 27 mojom.INT64: "0",
28 mojom.UINT64: "0", 28 mojom.UINT64: "0",
29 mojom.DOUBLE: "0", 29 mojom.DOUBLE: "0",
30 mojom.STRING: '""', 30 mojom.STRING: '""',
31 } 31 }
32 32
33 33
34 def JavaScriptDefaultValue(field): 34 def JavaScriptDefaultValue(field):
35 if field.default: 35 if field.default:
36 return field.default 36 if isinstance(field.default, list):
37 # TODO(mpcomplete): This will need to be more sophisticated to support
38 # arrays of objects/arrays.
39 return "[" + ", ".join(field.default) + "]"
40 else:
41 return field.default
37 if field.kind in mojom.PRIMITIVES: 42 if field.kind in mojom.PRIMITIVES:
38 return _kind_to_javascript_default_value[field.kind] 43 return _kind_to_javascript_default_value[field.kind]
39 if isinstance(field.kind, mojom.Struct): 44 if isinstance(field.kind, mojom.Struct):
40 return "null"; 45 return "null";
41 if isinstance(field.kind, mojom.Array): 46 if isinstance(field.kind, mojom.Array):
42 return "[]"; 47 return "[]";
43 48
44 49
45 def JavaScriptPayloadSize(packed): 50 def JavaScriptPayloadSize(packed):
46 packed_fields = packed.packed_fields 51 packed_fields = packed.packed_fields
(...skipping 106 matching lines...) Expand 10 before | Expand all | Expand 10 after
153 @UseJinja("js_templates/module.js.tmpl", filters=js_filters) 158 @UseJinja("js_templates/module.js.tmpl", filters=js_filters)
154 def GenerateJsModule(self): 159 def GenerateJsModule(self):
155 return { 160 return {
156 "enums": self.module.enums, 161 "enums": self.module.enums,
157 "structs": self.GetStructs() + self.GetStructsFromMethods(), 162 "structs": self.GetStructs() + self.GetStructsFromMethods(),
158 "interfaces": self.module.interfaces, 163 "interfaces": self.module.interfaces,
159 } 164 }
160 165
161 def GenerateFiles(self): 166 def GenerateFiles(self):
162 self.Write(self.GenerateJsModule(), "%s.js" % self.module.name) 167 self.Write(self.GenerateJsModule(), "%s.js" % self.module.name)
OLDNEW
« no previous file with comments | « mojo/public/bindings/generators/mojom_cpp_generator.py ('k') | mojo/public/bindings/pylib/parse/mojo_parser.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698