Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 1418813010: Notifications custom layouts: make the buttons look good in Material. (Closed)

Created:
5 years, 1 month ago by Michael van Ouwerkerk
Modified:
5 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Notifications custom layouts: make the buttons look good in Material. * Tweak the spacing to be identical to the standard layout * Tweak the ripple to look good BUG=541617 Committed: https://crrev.com/b0e8235529763657e30904be1cb34ec979495291 Cr-Commit-Position: refs/heads/master@{#357074}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
A + chrome/android/java/res/drawable-v21/web_notification_button_background.xml View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/res/layout/web_notification_big.xml View 2 chunks +2 lines, -2 lines 2 comments Download
M chrome/android/java/res/layout/web_notification_button.xml View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/res/values-v21/styles.xml View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Michael van Ouwerkerk
Peter, Newton, can you take a look please?
5 years, 1 month ago (2015-10-29 17:01:32 UTC) #2
Peter Beverloo
lgtm https://codereview.chromium.org/1418813010/diff/1/chrome/android/java/res/layout/web_notification_big.xml File chrome/android/java/res/layout/web_notification_big.xml (right): https://codereview.chromium.org/1418813010/diff/1/chrome/android/java/res/layout/web_notification_big.xml#newcode96 chrome/android/java/res/layout/web_notification_big.xml:96: <ImageView Is the 14dp reduction in height enough ...
5 years, 1 month ago (2015-10-29 17:33:28 UTC) #3
Michael van Ouwerkerk
https://codereview.chromium.org/1418813010/diff/1/chrome/android/java/res/layout/web_notification_big.xml File chrome/android/java/res/layout/web_notification_big.xml (right): https://codereview.chromium.org/1418813010/diff/1/chrome/android/java/res/layout/web_notification_big.xml#newcode96 chrome/android/java/res/layout/web_notification_big.xml:96: <ImageView On 2015/10/29 17:33:28, Peter Beverloo wrote: > Is ...
5 years, 1 month ago (2015-10-29 17:41:07 UTC) #4
newt (away)
lgtm
5 years, 1 month ago (2015-10-29 20:43:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1418813010/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1418813010/1
5 years, 1 month ago (2015-10-30 09:49:14 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-30 10:29:09 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-10-30 10:29:58 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b0e8235529763657e30904be1cb34ec979495291
Cr-Commit-Position: refs/heads/master@{#357074}

Powered by Google App Engine
This is Rietveld 408576698