chrome/android/java/res/layout/web_notification_big.xml - Issue 1418813010: Notifications custom layouts: make the buttons look good in Material.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/res/layout/web_notification_big.xml

Issue 1418813010: Notifications custom layouts: make the buttons look good in Material. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/res/drawable-v21/web_notification_button_background.xml ('k') | chrome/android/java/res/layout/web_notification_button.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/res/layout/web_notification_big.xml

diff --git a/chrome/android/java/res/layout/web_notification_big.xml b/chrome/android/java/res/layout/web_notification_big.xml

index 2b9251011a1fb3db6ed4ca8897c67c9c36138db1..f79c451d82b759310873198152bc8770161b6ee5 100644

--- a/chrome/android/java/res/layout/web_notification_big.xml

+++ b/chrome/android/java/res/layout/web_notification_big.xml

@@ -81,7 +81,7 @@

style="@style/WebNotificationDivider"

android:layout_width="match_parent"

android:layout_height="1dp"

- android:layout_marginBottom="8dp"

+ android:layout_marginTop="2dp"

android:contentDescription="@null"

android:visibility="gone"/>

@@ -89,8 +89,8 @@

android:id="@+id/buttons"

android:layout_width="match_parent"

android:layout_height="wrap_content"

+ android:layout_marginStart="-8dp"

android:orientation="horizontal"

- android:layout_marginBottom="8dp"

android:visibility="gone"/>

<ImageView

Peter Beverloo 2015/10/29 17:33:28 Is the 14dp reduction in height enough to make the

Michael van Ouwerkerk 2015/10/29 17:41:07 Yes, together with the timestamp spacing CL (https