Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Side by Side Diff: chrome/android/java/res/layout/web_notification_big.xml

Issue 1418813010: Notifications custom layouts: make the buttons look good in Material. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <?xml version="1.0" encoding="utf-8"?> 1 <?xml version="1.0" encoding="utf-8"?>
2 <!-- Copyright 2015 The Chromium Authors. All rights reserved. 2 <!-- Copyright 2015 The Chromium Authors. All rights reserved.
3 Use of this source code is governed by a BSD-style license that can be 3 Use of this source code is governed by a BSD-style license that can be
4 found in the LICENSE file. --> 4 found in the LICENSE file. -->
5 5
6 <!-- 6 <!--
7 Web notification custom layout, big state. 7 Web notification custom layout, big state.
8 _______________________________________________________ 8 _______________________________________________________
9 | | | 9 | | |
10 | Icon | Title text 1:23 pm | 10 | Icon | Title text 1:23 pm |
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
74 android:layout_marginEnd="6dp" 74 android:layout_marginEnd="6dp"
75 android:layout_marginBottom="8dp" 75 android:layout_marginBottom="8dp"
76 android:maxLines="8" 76 android:maxLines="8"
77 android:ellipsize="end"/> 77 android:ellipsize="end"/>
78 78
79 <ImageView 79 <ImageView
80 android:id="@+id/button_divider" 80 android:id="@+id/button_divider"
81 style="@style/WebNotificationDivider" 81 style="@style/WebNotificationDivider"
82 android:layout_width="match_parent" 82 android:layout_width="match_parent"
83 android:layout_height="1dp" 83 android:layout_height="1dp"
84 android:layout_marginBottom="8dp" 84 android:layout_marginTop="2dp"
85 android:contentDescription="@null" 85 android:contentDescription="@null"
86 android:visibility="gone"/> 86 android:visibility="gone"/>
87 87
88 <LinearLayout 88 <LinearLayout
89 android:id="@+id/buttons" 89 android:id="@+id/buttons"
90 android:layout_width="match_parent" 90 android:layout_width="match_parent"
91 android:layout_height="wrap_content" 91 android:layout_height="wrap_content"
92 android:layout_marginStart="-8dp"
92 android:orientation="horizontal" 93 android:orientation="horizontal"
93 android:layout_marginBottom="8dp"
94 android:visibility="gone"/> 94 android:visibility="gone"/>
95 95
96 <ImageView 96 <ImageView
Peter Beverloo 2015/10/29 17:33:28 Is the 14dp reduction in height enough to make the
Michael van Ouwerkerk 2015/10/29 17:41:07 Yes, together with the timestamp spacing CL (https
97 android:id="@+id/footer_divider" 97 android:id="@+id/footer_divider"
98 style="@style/WebNotificationDivider" 98 style="@style/WebNotificationDivider"
99 android:layout_width="match_parent" 99 android:layout_width="match_parent"
100 android:layout_height="1dp" 100 android:layout_height="1dp"
101 android:layout_marginBottom="8dp" 101 android:layout_marginBottom="8dp"
102 android:contentDescription="@null"/> 102 android:contentDescription="@null"/>
103 103
104 <TextView 104 <TextView
105 android:id="@+id/origin" 105 android:id="@+id/origin"
106 style="@style/WebNotificationOrigin" 106 style="@style/WebNotificationOrigin"
107 android:layout_width="match_parent" 107 android:layout_width="match_parent"
108 android:layout_height="wrap_content" 108 android:layout_height="wrap_content"
109 android:layout_marginBottom="10dp" 109 android:layout_marginBottom="10dp"
110 android:singleLine="true" 110 android:singleLine="true"
111 android:ellipsize="end"/> 111 android:ellipsize="end"/>
112 112
113 </LinearLayout> 113 </LinearLayout>
114 114
115 </RelativeLayout> 115 </RelativeLayout>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698