Issue 1418813005: Instrinsics on object pool architectures must preserve CODE_REG.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1418813005: Instrinsics on object pool architectures must preserve CODE_REG. (Closed)

Created:
5 years, 2 months ago by rmacnak

Modified:
5 years, 1 month ago

Reviewers:
Florian Schneider

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Instrinsics on object pool architectures must preserve CODE_REG. This fixes c13b481aeb15a52e778c9ea2fbc98a6dfa0bafb3. IA32 does not load a constant pool and does not use the CODE_REG to create the pc marker, so it does not need to preserve CODE_REG in instrinsics. Blocking another register from graph instrinsics caused some of them to need to spill, which is asserted to never happen. R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/c483ba84516e3bcfd5cd6e620b8c35bc187ac983

Patch Set 1 #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -0 lines)			Patch
	M	runtime/vm/flow_graph_allocator.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
	M	runtime/vm/flow_graph_compiler.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

rmacnak

5 years, 1 month ago (2015-10-26 16:13:16 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
c483ba84516e3bcfd5cd6e620b8c35bc187ac983 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages