Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Side by Side Diff: runtime/vm/flow_graph_compiler.cc

Issue 1418813005: Instrinsics on object pool architectures must preserve CODE_REG. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/flow_graph_allocator.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_XXX. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_XXX.
6 6
7 #include "vm/flow_graph_compiler.h" 7 #include "vm/flow_graph_compiler.h"
8 8
9 #include "vm/bit_vector.h" 9 #include "vm/bit_vector.h"
10 #include "vm/cha.h" 10 #include "vm/cha.h"
(...skipping 1535 matching lines...) Expand 10 before | Expand all | Expand 10 after
1546 1546
1547 ParallelMoveResolver::ScratchRegisterScope::ScratchRegisterScope( 1547 ParallelMoveResolver::ScratchRegisterScope::ScratchRegisterScope(
1548 ParallelMoveResolver* resolver, Register blocked) 1548 ParallelMoveResolver* resolver, Register blocked)
1549 : resolver_(resolver), 1549 : resolver_(resolver),
1550 reg_(kNoRegister), 1550 reg_(kNoRegister),
1551 spilled_(false) { 1551 spilled_(false) {
1552 uword blocked_mask = RegMaskBit(blocked) | kReservedCpuRegisters; 1552 uword blocked_mask = RegMaskBit(blocked) | kReservedCpuRegisters;
1553 if (resolver->compiler_->intrinsic_mode()) { 1553 if (resolver->compiler_->intrinsic_mode()) {
1554 // Block additional registers that must be preserved for intrinsics. 1554 // Block additional registers that must be preserved for intrinsics.
1555 blocked_mask |= RegMaskBit(ARGS_DESC_REG); 1555 blocked_mask |= RegMaskBit(ARGS_DESC_REG);
1556 #if !defined(TARGET_ARCH_IA32)
1557 // Need to preserve CODE_REG to be able to store the PC marker
1558 // and load the pool pointer.
1559 blocked_mask |= RegMaskBit(CODE_REG);
1560 #endif
1556 } 1561 }
1557 reg_ = static_cast<Register>( 1562 reg_ = static_cast<Register>(
1558 resolver_->AllocateScratchRegister(Location::kRegister, 1563 resolver_->AllocateScratchRegister(Location::kRegister,
1559 blocked_mask, 1564 blocked_mask,
1560 0, 1565 0,
1561 kNumberOfCpuRegisters - 1, 1566 kNumberOfCpuRegisters - 1,
1562 &spilled_)); 1567 &spilled_));
1563 1568
1564 if (spilled_) { 1569 if (spilled_) {
1565 resolver->SpillScratch(reg_); 1570 resolver->SpillScratch(reg_);
(...skipping 249 matching lines...) Expand 10 before | Expand all | Expand 10 after
1815 1820
1816 1821
1817 void FlowGraphCompiler::FrameStateClear() { 1822 void FlowGraphCompiler::FrameStateClear() {
1818 ASSERT(!is_optimizing()); 1823 ASSERT(!is_optimizing());
1819 frame_state_.TruncateTo(0); 1824 frame_state_.TruncateTo(0);
1820 } 1825 }
1821 #endif 1826 #endif
1822 1827
1823 1828
1824 } // namespace dart 1829 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/vm/flow_graph_allocator.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698