Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1418763003: DevTools: [SSP] treat new rules out of style cascade. (Closed)

Created:
5 years, 1 month ago by lushnikov
Modified:
5 years, 1 month ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, blink-reviews-style_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@kill-style-rule
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: [SSP] treat new rules out of style cascade. Currently, as a new rule gets added with "+" button in StylesSidebarPane, its properties are treated as a part of a style cascade. This results in some of them being crossed-out, and some of them overriding properties from other styles. However, this is almost always wrong, as it doesn't respect rule's selector specificity. This patch pulls new rule out of styles cascade, so its properties are never crossed-out and it never overrides other style's properties. BUG=none R=pfeldman, dgozman Committed: https://crrev.com/b9194aa7a2ffd7e1463eeb9257027820b3658bd8 Cr-Commit-Position: refs/heads/master@{#358518}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -19 lines) Patch
M third_party/WebKit/Source/devtools/front_end/elements/StylesSectionModel.js View 1 chunk +0 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js View 2 chunks +0 lines, -3 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 7 (2 generated)
lushnikov
ptal
5 years, 1 month ago (2015-11-07 02:16:50 UTC) #1
dgozman
lgtm
5 years, 1 month ago (2015-11-07 03:05:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1418763003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1418763003/1
5 years, 1 month ago (2015-11-07 05:53:58 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-07 07:05:58 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-07 07:06:51 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b9194aa7a2ffd7e1463eeb9257027820b3658bd8
Cr-Commit-Position: refs/heads/master@{#358518}

Powered by Google App Engine
This is Rietveld 408576698