DevTools: kill WebInspector.StylesSectionModel class

DevTools: kill WebInspector.StylesSectionModel class

Class WI.StylesSectionModel was a presentation model used by
StyleSidebarPane to render its sections.

The patch removes WI.StylesSectionModel class and starts
using plain WI.CSSStyleDeclaration objects in WI.StylePropertiesSection
for its rendering.

BUG=537827
R=pfeldman, dgozman

Committed: https://crrev.com/02bf90ea78699cf01f1b165aace07fa58ffc09b0
Cr-Commit-Position: refs/heads/master@{#358515}

[lushnikov, 2015-11-07 02:03:32]

ptal

[lushnikov, 2015-11-07 02:03:54]

Description was changed from

==========
DevTools: kill WebInspector.StylesSectionModel class

Class WI.StylesSectionModel was a presentation model and was used by
StyleSidebarPane to render its sections.

The patch removes WI.StylesSectionModel class and starts
using plain WI.CSSStyleDeclaration objects in WI.StylePropertiesSection
for its rendering.

BUG=537827
R=pfeldman, dgozman
==========

to

==========
DevTools: kill WebInspector.StylesSectionModel class

Class WI.StylesSectionModel was a presentation model used by
StyleSidebarPane to render its sections.

The patch removes WI.StylesSectionModel class and starts
using plain WI.CSSStyleDeclaration objects in WI.StylePropertiesSection
for its rendering.

BUG=537827
R=pfeldman, dgozman
==========

[lushnikov, 2015-11-07 02:04:36]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-07 02:05:09]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1434613002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1434613002/1

[dgozman, 2015-11-07 03:00:54]

lgtm

https://codereview.chromium.org/1434613002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/http/tests/inspector/elements-test.js
(right):

https://codereview.chromium.org/1434613002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/inspector/elements-test.js:358: if
(section._style.parentRule && excludeMatched)
style()

https://codereview.chromium.org/1434613002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/inspector/elements/styles-1/add-new-rule-inline-style-csp.html
(right):

https://codereview.chromium.org/1434613002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector/elements/styles-1/add-new-rule-inline-style-csp.html:31:
rule = section._style.parentRule;
style()

https://codereview.chromium.org/1434613002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/inspector/elements/styles-4/styles-update-links.html
(right):

https://codereview.chromium.org/1434613002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector/elements/styles-4/styles-update-links.html:124:
var rule = section._style.parentRule;
style()

https://codereview.chromium.org/1434613002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/inspector/elements/styles-4/undo-add-new-rule.html
(right):

https://codereview.chromium.org/1434613002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector/elements/styles-4/undo-add-new-rule.html:74:
var id = section._style.styleSheetId;
style()

https://codereview.chromium.org/1434613002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js
(right):

https://codereview.chromium.org/1434613002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js:472:
var parentNode = matchedCascade.isInherited(style) ?
matchedCascade.nodeForStyle(style) : null;
Should we kill isInherited?

https://codereview.chromium.org/1434613002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js:766:
this.editable = style.styleSheetId && style.range;
!!(expression)

https://codereview.chromium.org/1434613002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js:1216:
var rule = this._style.parentRule
semicolon

https://codereview.chromium.org/1434613002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js:1427:
var rule = this._style.parentRule
semicolon

https://codereview.chromium.org/1434613002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js:1805:
this._style = property.ownerStyle;
Remove this.

[lushnikov, 2015-11-07 03:09:25]

https://codereview.chromium.org/1434613002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/http/tests/inspector/elements-test.js
(right):

https://codereview.chromium.org/1434613002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/inspector/elements-test.js:358: if
(section._style.parentRule && excludeMatched)
On 2015/11/07 03:00:53, dgozman wrote:
> style()

Done.

https://codereview.chromium.org/1434613002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/inspector/elements/styles-1/add-new-rule-inline-style-csp.html
(right):

https://codereview.chromium.org/1434613002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector/elements/styles-1/add-new-rule-inline-style-csp.html:31:
rule = section._style.parentRule;
On 2015/11/07 03:00:53, dgozman wrote:
> style()

Done.

https://codereview.chromium.org/1434613002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/inspector/elements/styles-4/styles-update-links.html
(right):

https://codereview.chromium.org/1434613002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector/elements/styles-4/styles-update-links.html:124:
var rule = section._style.parentRule;
On 2015/11/07 03:00:53, dgozman wrote:
> style()

Done.

https://codereview.chromium.org/1434613002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/inspector/elements/styles-4/undo-add-new-rule.html
(right):

https://codereview.chromium.org/1434613002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector/elements/styles-4/undo-add-new-rule.html:74:
var id = section._style.styleSheetId;
On 2015/11/07 03:00:53, dgozman wrote:
> style()

Done.

https://codereview.chromium.org/1434613002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js
(right):

https://codereview.chromium.org/1434613002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js:472:
var parentNode = matchedCascade.isInherited(style) ?
matchedCascade.nodeForStyle(style) : null;
Nope!

https://codereview.chromium.org/1434613002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js:766:
this.editable = style.styleSheetId && style.range;
On 2015/11/07 03:00:53, dgozman wrote:
> !!(expression)

Done.

https://codereview.chromium.org/1434613002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js:1216:
var rule = this._style.parentRule
On 2015/11/07 03:00:54, dgozman wrote:
> semicolon

Done.

https://codereview.chromium.org/1434613002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js:1427:
var rule = this._style.parentRule
On 2015/11/07 03:00:54, dgozman wrote:
> semicolon

Done.

https://codereview.chromium.org/1434613002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js:1805:
this._style = property.ownerStyle;
On 2015/11/07 03:00:53, dgozman wrote:
> Remove this.

Done.

[commit-bot: I haz the power, 2015-11-07 03:13:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-07 03:13:34]

Dry run: This issue passed the CQ dry run.

[lushnikov, 2015-11-07 03:15:26]

The CQ bit was checked by lushnikov@chromium.org

[lushnikov, 2015-11-07 03:15:26]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/1434613002/#ps20001
(title: "address comments")

[commit-bot: I haz the power, 2015-11-07 03:15:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1434613002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1434613002/20001

[commit-bot: I haz the power, 2015-11-07 04:30:20]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-07 04:31:27]

Patchset 2 (id:??) landed as
https://crrev.com/02bf90ea78699cf01f1b165aace07fa58ffc09b0
Cr-Commit-Position: refs/heads/master@{#358515}